From 8b7ba054a7239fbc71a296d77dbe65615e77ac66 Mon Sep 17 00:00:00 2001
From: Wei Luning <weiluning@huawei.com>
Date: Wed, 20 May 2020 17:50:41 +0800
Subject: [PATCH] Add notes for compiler sig meeting notes 001-2020-518

---
 sigs/compiler/meetings/001-20200518.md | 22 ---------------------
 sigs/compiler/meetings/001-20200519.md | 27 ++++++++++++++++++++++++++
 2 files changed, 27 insertions(+), 22 deletions(-)
 delete mode 100644 sigs/compiler/meetings/001-20200518.md
 create mode 100644 sigs/compiler/meetings/001-20200519.md

diff --git a/sigs/compiler/meetings/001-20200518.md b/sigs/compiler/meetings/001-20200518.md
deleted file mode 100644
index 6406505..0000000
--- a/sigs/compiler/meetings/001-20200518.md
+++ /dev/null
@@ -1,22 +0,0 @@
-# Tuesday May 18, 2020 at 18:20pm GMT+8
-
-## Agenda
-
-* Review the design for Sparse update for GatherV2.
-
-## Conference links
-
-https://meet.jit.si/MindSporeCimpilerSIG
-
-## Attendees
-
-* Pan Yifeng (Huawei)
-* Wei Luning (Huawei)
-* Zhao Zhiqiang (Huawei)
-* Huang Dongrun (Huawei)
-
-## Notes
-
-## Action items
-
-* None
diff --git a/sigs/compiler/meetings/001-20200519.md b/sigs/compiler/meetings/001-20200519.md
new file mode 100644
index 0000000..9510f38
--- /dev/null
+++ b/sigs/compiler/meetings/001-20200519.md
@@ -0,0 +1,27 @@
+# Tuesday May 18, 2020 at 18:20pm GMT+8
+
+## Agenda
+
+* Review the design for Sparse update for GatherV2.
+
+## Conference links
+
+https://meet.jit.si/MindSporeCimpilerSIG
+
+## Attendees
+
+* Pan Yifeng (Huawei)
+* Wei Luning (Huawei)
+* Zhao Zhiqiang (Huawei)
+* Huang Dongrun (Huawei)
+
+## Notes
+
+1. The long-term solution is to support the `SparseTensor` feature (inherited from `MetaTensor`), but the landing period will be longer.
+2. The quick support solution is to express this sparse structure with `DataClass`, and `Class` will be convert to `tuple` in `clean.cc`. The implement can reference `SequenceIterator`, and use `MultiType` to add a overload for add op and gradient update, if necessary.
+3. `GatherV2` can use the `ScatterNDUpdate` to update the gradient.
+
+## Action items
+
+* Make a demo with `DataClass`.
+* Design the full solution for `SparseTensor`.