Gintas Grigelionis
3f90aeba03
Use diamonds
8 years ago
Gintas Grigelionis
95495d57aa
Remove extraneous casts and (un)boxing, tersify logic
8 years ago
Gintas Grigelionis
1c80d507f4
Use foreach loops
8 years ago
Jaikiran Pai
242d661161
Deprecate SymbolicLinkUtils in favour of Java 7 java.nio.file.Files APIs
8 years ago
Gintas Grigelionis
7f1e7628b3
Checkstyle: whitespace, line continuation and modifier idiosyncrasies
8 years ago
Gintas Grigelionis
6656db28bb
Let’s use doclint
8 years ago
Matt Benson
b7d1e9bde4
java 5-8
9 years ago
Stefan Bodewig
45152b5208
Sonar meets backwards compatibility requirements
9 years ago
Stefan Bodewig
df33426bf2
whitespace
11 years ago
Jan Matèrne
13f6d98c9d
make it compile under Java5 (1.5.0_22-b03)
12 years ago
Jan Matèrne
1b76f1b6da
checkstyle
12 years ago
Jan Materne
bed22b00f7
JavaDoc fixes (for Java8 doclint) - first bunch
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1586262 13f79535-47bb-0310-9956-ffa450edef68
12 years ago
Stefan Bodewig
bea36bbd2b
don't assume File#isDirectory == !File#isFile - i.e. explicitly test
and drop objects that are neither files nor directories. PR 56149
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1573999 13f79535-47bb-0310-9956-ffa450edef68
12 years ago
Stefan Bodewig
5fc48a4bf9
assorted spelling fixes by Lajos Veres - closes #4
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1572981 13f79535-47bb-0310-9956-ffa450edef68
12 years ago
Stefan Bodewig
e46fd219c3
removeNotFollowedSymlinks='true' might be deleting too eagerly. PR 53959
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1555490 13f79535-47bb-0310-9956-ffa450edef68
12 years ago
Matthew Jason Benson
3d706ab818
java 5 updates
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1375137 13f79535-47bb-0310-9956-ffa450edef68
13 years ago
Stefan Bodewig
40a73d22b7
whitespace
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1234277 13f79535-47bb-0310-9956-ffa450edef68
14 years ago
Stefan Bodewig
379895a022
synchronize access to default excludes. PR 52188.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1234276 13f79535-47bb-0310-9956-ffa450edef68
14 years ago
Stefan Bodewig
a28f64f5cf
fix a bunch of warnings you get when building on Harmony which uses Eclipse's compiler. There are still lots (more than 100) of deprecation warnings and warnings about missing serialversionids that I have ignored.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1037691 13f79535-47bb-0310-9956-ffa450edef68
15 years ago
Stefan Bodewig
d85d2da8e3
restrict impact of fix for PR 50295 on 'good' VMs to an additional syscall for empty directories rather than an additional call for every directory
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1036906 13f79535-47bb-0310-9956-ffa450edef68
15 years ago
Stefan Bodewig
17d4b3461a
Make DirectoryScanner work on buggy JVMs where File.list() returns an empty array rather than null for files. PR 50295. Submitted by Daniel Smith
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@1036905 13f79535-47bb-0310-9956-ffa450edef68
15 years ago
Stefan Bodewig
43de42a38f
add Git, Mercurial and Bazaar files/dirs to defaultexcludes. Submitted by Ville Skyttä. PR 49624
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@982469 13f79535-47bb-0310-9956-ffa450edef68
15 years ago
Stefan Bodewig
6a87b53fcb
don't scan directories that are excluded recursively - this used to be done everywhere except for the (most common) case where the directory itself was not explicitly included. PR 49420
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@953281 13f79535-47bb-0310-9956-ffa450edef68
16 years ago
Stefan Bodewig
e052e5e8dc
some JUnit tests to verify/falsify http://mail-archives.apache.org/mod_mbox/ant-user/201006.mbox/%3C28829117.post@talk.nabble.com%3E
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@953046 13f79535-47bb-0310-9956-ffa450edef68
16 years ago
Stefan Bodewig
66b7fa5b87
slow-scan was broken for recursive exclude patterns since contentsExcluded was added about four years ago
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@727993 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
b1cc0a4edb
slowscan has been broken, no idea since when.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@727739 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
5f7fbe8b73
keep track of links that haven't been followed
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@713626 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
9f30d05509
factor out symlink methods into a separate utils class
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@702350 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
2e5eacfa9c
increase default for numer of times a symlink may be traversed
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@697692 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
be09d4522b
no need to clone a linked list to iterate through it
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@697073 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
9b76a8661b
remove memoization which measurably (sp?) hurts performance more than it helps
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@697032 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
acb91faca4
replace protected Vectors with a Vector subclass that has constant time access for contains
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@696674 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
4ecea70e9b
Bring back memoization of File.list
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@696355 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
8b58203e31
avoid redundant tokenization of non-wildcard include patterns as well.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@696345 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
2c4faa154f
avoid redundant tokenization. this is almost complete except for non-wildcard include patterns, will take care of them next.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@696336 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
2b925503d7
avoid some tokenization (should really pay of in the next iteration/s) and replace recursion with iteration in findFile/isSymLink - right now we lose memoization of File.list but I'll reintroduce this later.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@696298 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
5d1320e99c
split PathPattern into two classes, more behavior will be added later
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@696146 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
a98a49253b
minor performace tweaks
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@696144 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
c13dba6d52
Avoid repeated tokenization, make DefaultExcludesTest happy.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@695402 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
e362b3b1fc
tiny optimization
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@695389 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
917f222eec
whitespace
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@695380 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
4c6cba963c
extract constant
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@695379 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
7830ff460d
some more memoization. try to ballance memory vs i/o costs.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@695371 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
cd517c2881
fix tests broken by changed exception message of svn revision 685593
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@694254 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
1d3ca73f3c
don't run into infinite lopps caused by symbolic links. PR 45499.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@693870 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
4464369821
honor followsymlinks on a fileset's dir as well. PR 45741.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@693846 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
4248bab8ea
make sure the 'correct' error is reported if the directory doesn't exist. Sync error messages of DirectoryScanner and AbstractFileSet.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@693791 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Stefan Bodewig
a87871c71e
some style changes, doc fixes (non-wildcard patterns are store upper-case), some minor optimizations and some additional memoization of File.list() that may actually improve performance
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@693785 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Scokart Gilles
1f06891d00
Enhance performance of DirectoryScanner by parsing the patterns only once. Introduce a PathPattern to do that. (# 44226)
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@687768 13f79535-47bb-0310-9956-ffa450edef68
17 years ago
Jesse N. Glick
cafa34ca08
Various microoptimizations to reduce I/O load of common tasks, esp. no-op <javac> and <depend>.
Many inner loops altered to make just 1-2 system calls rather than 4-5.
You can easily see how wasteful the previous code was, and find the culprits,
by patching r/o java.io.File methods and adding to -Xbootclasspath/p (or use AspectJ). E.g.:
public boolean isDirectory() {
System.err.println("isDirectory: " + this); if (Math.random() < .01) Thread.dumpStack();
// as before...
}
Ant still makes an order of magnitude more system calls to do what seem like simple operations
than you would think necessary, but this patch should at least improve the situation.
git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@581748 13f79535-47bb-0310-9956-ffa450edef68
18 years ago