From f7e6cdd1f9b80e683aaf9522c067d383b0de971c Mon Sep 17 00:00:00 2001
From: Peter Donald <donaldp@apache.org>
Date: Sun, 23 Dec 2001 06:17:15 +0000
Subject: [PATCH] Set the output stremes via setters not via constructor

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@270355 13f79535-47bb-0310-9956-ffa450edef68
---
 .../myrmidon/src/java/org/apache/antlib/cvslib/Cvs.java  | 9 ++++-----
 .../org/apache/myrmidon/framework/exec/Environment.java  | 8 +++++---
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/proposal/myrmidon/src/java/org/apache/antlib/cvslib/Cvs.java b/proposal/myrmidon/src/java/org/apache/antlib/cvslib/Cvs.java
index d824981be..2ddbcb8cf 100644
--- a/proposal/myrmidon/src/java/org/apache/antlib/cvslib/Cvs.java
+++ b/proposal/myrmidon/src/java/org/apache/antlib/cvslib/Cvs.java
@@ -14,6 +14,7 @@ import org.apache.myrmidon.api.TaskException;
 import org.apache.tools.ant.Project;
 import org.apache.tools.ant.taskdefs.exec.Execute;
 import org.apache.tools.ant.taskdefs.exec.LogStreamHandler;
+import org.apache.tools.ant.taskdefs.exec.LogOutputStream;
 import org.apache.tools.ant.types.Commandline;
 import org.apache.tools.ant.types.EnvironmentData;
 import org.apache.tools.ant.types.EnvironmentVariable;
@@ -147,11 +148,9 @@ public class Cvs
         final Commandline command = buildCommandline();
         final EnvironmentData env = buildEnvironment();
 
-        //FIXME:
-        final LogStreamHandler streamhandler =
-            new LogStreamHandler( null, Project.MSG_INFO, Project.MSG_WARN );
-
-        final Execute exe = new Execute( streamhandler, null );
+        final Execute exe = new Execute();
+        exe.setOutput( new LogOutputStream( null, Project.MSG_INFO ) );
+        exe.setError( new LogOutputStream( null, Project.MSG_WARN ) );
         if( m_dest == null ) m_dest = getBaseDirectory();
         exe.setWorkingDirectory( m_dest );
 
diff --git a/proposal/myrmidon/src/java/org/apache/myrmidon/framework/exec/Environment.java b/proposal/myrmidon/src/java/org/apache/myrmidon/framework/exec/Environment.java
index 1ba1586d9..ee6469b28 100644
--- a/proposal/myrmidon/src/java/org/apache/myrmidon/framework/exec/Environment.java
+++ b/proposal/myrmidon/src/java/org/apache/myrmidon/framework/exec/Environment.java
@@ -15,10 +15,9 @@ import java.util.ArrayList;
 import java.util.Iterator;
 import java.util.Locale;
 import java.util.Properties;
-import org.apache.myrmidon.framework.Os;
 import org.apache.myrmidon.api.TaskException;
+import org.apache.myrmidon.framework.Os;
 import org.apache.tools.ant.taskdefs.exec.Execute;
-import org.apache.tools.ant.taskdefs.exec.PumpStreamHandler;
 
 /**
  * This is the class that can be used to retrieve the environment
@@ -224,7 +223,10 @@ public final class Environment
         throws IOException, ExecException
     {
         final ByteArrayOutputStream output = new ByteArrayOutputStream();
-        final Execute exe = new Execute( new PumpStreamHandler( output ) );
+        final Execute exe = new Execute();
+        exe.setOutput( output );
+        exe.setError( output );
+
         exe.setCommandline( getEnvCommand() );
 
         // Make sure we do not recurse forever