Make changes so that tasks use the two arg replaceProperties() rather than 3 arg as it is lower coupling.

git-svn-id: https://svn.apache.org/repos/asf/ant/core/trunk@270063 13f79535-47bb-0310-9956-ffa450edef68

src/main/org/apache/tools/ant/Target.java

@@ -222,7 +222,7 @@ public class Target implements TaskContainer {
             return true;
         }
         
-        String test = ProjectHelper.replaceProperties(getProject(), ifCondition, getProject().getProperties());
+        String test = ProjectHelper.replaceProperties(getProject(), ifCondition);
         return project.getProperty(test) != null;
     }
 
@@ -230,7 +230,7 @@ public class Target implements TaskContainer {
         if ("".equals(unlessCondition)) {
             return true;
         }
-        String test = ProjectHelper.replaceProperties(getProject(), unlessCondition, getProject().getProperties());
+        String test = ProjectHelper.replaceProperties(getProject(), unlessCondition);
         return project.getProperty(test) == null;
     }
 }

src/main/org/apache/tools/ant/taskdefs/Echo.java

@@ -128,7 +128,7 @@ public class Echo extends Task {
      */
     public void addText(String msg) {
         message += 
-            ProjectHelper.replaceProperties(project, msg, project.getProperties());
+            ProjectHelper.replaceProperties(project, msg);
     }
 
     /**

src/main/org/apache/tools/ant/taskdefs/Exit.java

@@ -84,7 +84,7 @@ public class Exit extends Task {
      */
     public void addText(String msg) {
         message += 
-            ProjectHelper.replaceProperties(project, msg, project.getProperties());
+            ProjectHelper.replaceProperties(project, msg);
     }
 
 }

src/main/org/apache/tools/ant/taskdefs/Input.java

@@ -204,7 +204,7 @@ public class Input extends Task {
      */
     public void addText(String msg) {
         message +=
-            ProjectHelper.replaceProperties(project, msg, project.getProperties());
+            ProjectHelper.replaceProperties(project, msg);
     }
 }
 

src/main/org/apache/tools/ant/taskdefs/Javadoc.java

@@ -1146,8 +1146,7 @@ public class Javadoc extends Task {
      * Convenience method to expand properties.
      */
     protected String expand(String content) {
-        return ProjectHelper.replaceProperties(project, content,
-                                               project.getProperties());
+        return ProjectHelper.replaceProperties(project, content);
     }
 
     private String getJavadocExecutableName()

src/main/org/apache/tools/ant/taskdefs/Property.java

@@ -280,7 +280,7 @@ public class Property extends Task {
             String name = (String) e.nextElement();
             String value = (String) props.getProperty(name);
 
-            String v = ProjectHelper.replaceProperties(project, value, project.getProperties());
+            String v = ProjectHelper.replaceProperties(project, value);
             addProperty(name, v);
         }
     }

src/main/org/apache/tools/ant/taskdefs/SQLExec.java

@@ -533,8 +533,7 @@ public class SQLExec extends Task {
         try{
             while ((line=in.readLine()) != null){
                 line = line.trim();
-                line = ProjectHelper.replaceProperties(project, line,
-                                                       project.getProperties());
+                line = ProjectHelper.replaceProperties(project, line);
                 if (line.startsWith("//")) continue;
                 if (line.startsWith("--")) continue;
                 StringTokenizer st = new StringTokenizer(line);

src/main/org/apache/tools/ant/types/PatternSet.java

@@ -291,8 +291,7 @@ public class PatternSet extends DataType {
             String line = patternReader.readLine();
             while (line != null) {
                 if (line.length() > 0) {
-                    line = ProjectHelper.replaceProperties(p, line,
-                                                           p.getProperties());
+                    line = ProjectHelper.replaceProperties(p, line);
                     addPatternToList(patternlist).setName(line);
                 }
                 line = patternReader.readLine();