aiforge

Tree: ba5ba4e8af

History

Kyle Evans 1d6bdf0c87 Allow unauthenticated users to compare (#11240 ) * routers: make /compare route available to unauthenticated users Remove some bits of the compare interface if the user isn't signed in. Notably, they don't need to see the "New Pull Request" button box nor the hidden form that would fail to submit due to the POST request continuing to require proper privileges. Follow-up commits will improve the UI a bit around this, removing some "Pull Request" verbiage in favor of "Compare." * ui: home: show "compare" button for unauthenticated users This change requires pulling in the BaseRepo unconditionally and recording if the pull request is in-fact not allowed (.PullRequestCtx.Allowed). If the user isn't allowed to create a pull request, either because this isn't a fork or same-fork branch PRs aren't allowed, then we'll name the button "Compare" instead of "Pull Request." * ui: branch list: use the new Compare language when available When viewing the branch listing as an unauthenticated user, you'll get "Pull Request" buttons. use the new "Compare" verbiage instead, which matches GitHub behavior when you can't issue a pull request from the branches. Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>	5 years ago
..
list.tmpl	Allow unauthenticated users to compare (#11240)	5 years ago

Kyle Evans 1d6bdf0c87 Allow unauthenticated users to compare (#11240 )

* routers: make /compare route available to unauthenticated users

Remove some bits of the compare interface if the user isn't signed in.
Notably, they don't need to see the "New Pull Request" button box nor the
hidden form that would fail to submit due to the POST request continuing to
require proper privileges.

Follow-up commits will improve the UI a bit around this, removing some
"Pull Request" verbiage in favor of "Compare."

* ui: home: show "compare" button for unauthenticated users

This change requires pulling in the BaseRepo unconditionally and
recording if the pull request is in-fact not allowed
(.PullRequestCtx.Allowed). If the user isn't allowed to create a pull
request, either because this isn't a fork or same-fork branch PRs aren't
allowed, then we'll name the button "Compare" instead of "Pull Request."

* ui: branch list: use the new Compare language when available

When viewing the branch listing as an unauthenticated user, you'll get
"Pull Request" buttons. use the new "Compare" verbiage instead, which
matches GitHub behavior when you can't issue a pull request from the
branches.

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>

5 years ago

..

list.tmpl

Allow unauthenticated users to compare (#11240)

5 years ago

No Description

Go SVG JavaScript Vue Roff other

u@gogs.io xiaolunwen@gmail.com teabot@gitea.io joe2010xtmf@163.com 747342561@qq.com art27@cantab.net zhoupzh@pcl.ac.cn lauris@nix.lv

gitea@fake.local me@silverwind.io sapk@users.noreply.github.com etk39@cornell.edu fuxiaohei@hexiaz.com andrey.nering@gmail.com thomas@webhippie.de 6543@obermui.de

xuchx@pcl.ac.cn ethantkoenig@gmail.com senluowanxiangt@gmail.com strk@kbt.io 42128690+jolheiser@users.noreply.github.com vslene@gmail.com appleboy.tw@gmail.com

Contributors (25+) All

Contributors (25+)
All