aiforge

13249 Commits

197 Branches

346 MB

19294 Download

Tree: deab16c880

Commit Graph

Author	SHA1	Message	Date
zeripath	c58bc4bf80	Prevent timer leaks in Workerpool and others (#11333 ) There is a potential memory leak in `Workerpool` due to the intricacies of `time.Timer` stopping. Whenever a `time.Timer` is `Stop`ped its channel must be cleared using a `select` if the result of the `Stop()` is `false`. Unfortunately in `Workerpool` these were checked the wrong way round. However, there were a few other places that were not being checked. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	6 years ago

Author

SHA1

Message

Date

zeripath

c58bc4bf80

Prevent timer leaks in Workerpool and others (#11333 )

There is a potential memory leak in `Workerpool` due to the intricacies of
`time.Timer` stopping.

Whenever a `time.Timer` is `Stop`ped its channel must be cleared using a
`select` if the result of the `Stop()` is `false`.

Unfortunately in `Workerpool` these were checked the wrong way round.

However, there were a few other places that were not being checked.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

6 years ago

1 Commits (deab16c88096480356570e527ffd18fa4586a6f1)