aiforge

346 MB

Tree: bc1ce1dad6

Author	SHA1	Message	Date
Tamal Saha	033fe113c1	Use gitea forked macaron (#7933 ) Signed-off-by: Tamal Saha <tamal@appscode.com>	6 years ago
WGH	4865cd6818	Fix lax comparison in validation tests (#7815 ) If you add t.Logf("%+v %+v", actual, testCase.expectedErrors) to the test code, you'll notice that only Errors' Messages are being compared: --- PASS: Test_ValidURLValidation/Invalid_schema (0.00s) binding_test.go:43: [Url] [Url] FieldNames and Classification are ignored in comparison. Moreover, an Errors slice with a single Error with empty message is formatted as '[]' (the same as empty slice), which is also error-prone. I discovered this when working on #7791 when one test which was not supposed to pass did pass. https://play.golang.org/p/qC4wVLrm4NG This commit changes the test to do the comparison properly.	6 years ago
kolaente	cdba91b438	Add golangci (#6418 )	6 years ago
Lauris BH	d1c82a5357	Better URL validation (#1507 ) * Add correct git branch name validation * Change git refname validation error constant name * Implement URL validation based on GoLang url.Parse method * Backward compatibility with older Go compiler * Add git reference name validation unit tests * Remove unused variable in unit test * Implement URL validation based on GoLang url.Parse method * Backward compatibility with older Go compiler * Add url validation unit tests	9 years ago