Browse Source

support reviewing on a deleted file path (#5880)

tags/v1.21.12.1
Lanre Adelowo Lunny Xiao 7 years ago
parent
commit
f9d4bd53e6
1 changed files with 3 additions and 2 deletions
  1. +3
    -2
      models/issue_comment.go

+ 3
- 2
models/issue_comment.go View File

@@ -873,10 +873,11 @@ func CreateCodeComment(doer *User, repo *Repository, issue *Issue, content, tree
// No need for get commit for base branch changes
if line > 0 {
commit, err := gitRepo.LineBlame(pr.GetGitRefName(), gitRepo.Path, treePath, uint(line))
if err != nil {
if err == nil {
commitID = commit.ID.String()
} else if err != nil && !strings.Contains(err.Error(), "exit status 128 - fatal: no such path") {
return nil, fmt.Errorf("LineBlame[%s, %s, %s, %d]: %v", pr.GetGitRefName(), gitRepo.Path, treePath, line, err)
}
commitID = commit.ID.String()
}

// Only fetch diff if comment is review comment


Loading…
Cancel
Save