From b3ca9a35c816cc4e4b570c89fef907c79719db6b Mon Sep 17 00:00:00 2001
From: liuzx <liuzx@pcl.ac.cn>
Date: Thu, 25 Nov 2021 17:05:36 +0800
Subject: [PATCH] fix bug

---
 routers/repo/modelarts.go | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/routers/repo/modelarts.go b/routers/repo/modelarts.go
index e7b2de3ec..5ad5a215e 100755
--- a/routers/repo/modelarts.go
+++ b/routers/repo/modelarts.go
@@ -485,20 +485,12 @@ func trainJobNewVersionDataPrepare(ctx *context.Context) error {
 	// 	ctx.ServerError("canNewJob can info failed", err)
 	// 	return err
 	// }
-	// ctx.Data["canNewJob"] = canNewJob
 
 	task, err := models.GetCloudbrainByJobIDAndVersionName(jobID, versionName)
 	if err != nil {
 		log.Error("GetCloudbrainByJobIDAndVersionName(%s) failed:%v", jobID, err.Error())
 		return err
 	}
-	//判断权限
-	canNewJob, err := canUserCreateTrainJobVersion(ctx, task.UserID)
-	if !canNewJob {
-		ctx.ServerError("user cann't new trainjob", err)
-		return err
-	}
-	ctx.Data["canNewJob"] = canNewJob
 
 	t := time.Now()
 	var jobName = cutString(ctx.User.Name, 5) + t.Format("2006010215") + strconv.Itoa(int(t.Unix()))[5:]
@@ -890,6 +882,13 @@ func TrainJobCreateVersion(ctx *context.Context, form auth.CreateModelArtsTrainJ
 	EngineName := form.EngineName
 	isLatestVersion := modelarts.IsLatestVersion
 
+	//判断权限
+	canNewJob, _ := canUserCreateTrainJobVersion(ctx, latestTask.UserID)
+	if !canNewJob {
+		ctx.RenderWithErr("user cann't new trainjob", tplModelArtsTrainJobVersionNew, &form)
+		return
+	}
+
 	if err := paramCheckCreateTrainJob(form); err != nil {
 		log.Error("paramCheckCreateTrainJob failed:(%v)", err)
 		VersionErrorDataPrepare(ctx, form)
@@ -936,6 +935,7 @@ func TrainJobCreateVersion(ctx *context.Context, form auth.CreateModelArtsTrainJ
 	}
 
 	parentDir := VersionOutputPath + "/"
+	// parentDir := ""
 	// if err := uploadCodeToObs(codeLocalPath, jobName, ""); err != nil {
 	if err := uploadCodeToObs(codeLocalPath, jobName, parentDir); err != nil {
 		log.Error("Failed to uploadCodeToObs: %s (%v)", repo.FullName(), err)