From 8b0c46c45de931de351cacc4eaa098fc3a4e8d47 Mon Sep 17 00:00:00 2001
From: Evgeny Proydakov <e.proydakov@gmail.com>
Date: Tue, 13 Oct 2020 16:20:05 +0300
Subject: [PATCH] A single approach was used to suppress the msvc C4996
 compiler warning [_CRT_SECURE_NO_WARNINGS] (#2208)

---
 benchmark/CMakeLists.txt | 6 ++++++
 benchmark/benchncnn.cpp  | 4 ----
 tests/CMakeLists.txt     | 5 +++++
 3 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/benchmark/CMakeLists.txt b/benchmark/CMakeLists.txt
index 7890733ca..39d09879d 100644
--- a/benchmark/CMakeLists.txt
+++ b/benchmark/CMakeLists.txt
@@ -1,3 +1,9 @@
+
+if(MSVC)
+    # warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
+    add_definitions(/wd4996)
+endif()
+
 add_executable(benchncnn benchncnn.cpp)
 target_link_libraries(benchncnn PRIVATE ncnn)
 
diff --git a/benchmark/benchncnn.cpp b/benchmark/benchncnn.cpp
index ea68ea734..26a3dfd2e 100644
--- a/benchmark/benchncnn.cpp
+++ b/benchmark/benchncnn.cpp
@@ -12,10 +12,6 @@
 // CONDITIONS OF ANY KIND, either express or implied. See the License for the
 // specific language governing permissions and limitations under the License.
 
-#ifdef _WIN32
-#define _CRT_SECURE_NO_WARNINGS
-#endif
-
 #include <float.h>
 #include <stdio.h>
 #include <string.h>
diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index cd56fbefd..f47a752f6 100644
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -1,4 +1,9 @@
 
+if(MSVC)
+    # warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
+    add_definitions(/wd4996)
+endif()
+
 macro(ncnn_add_test name)
     add_executable(test_${name} test_${name}.cpp)
     target_link_libraries(test_${name} PRIVATE ncnn)