From 303ae2ff36d1cfa23abdadb59dfaa4d25b9bfb82 Mon Sep 17 00:00:00 2001 From: pangda Date: Fri, 28 Oct 2022 15:26:17 +0800 Subject: [PATCH] [to #42322933] fix bug for text logger Link: https://code.alibaba-inc.com/Ali-MaaS/MaaS-lib/codereview/10560149 --- modelscope/trainers/hooks/logger/text_logger_hook.py | 2 +- modelscope/trainers/trainer.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modelscope/trainers/hooks/logger/text_logger_hook.py b/modelscope/trainers/hooks/logger/text_logger_hook.py index 8552ab4e..95644783 100644 --- a/modelscope/trainers/hooks/logger/text_logger_hook.py +++ b/modelscope/trainers/hooks/logger/text_logger_hook.py @@ -61,7 +61,7 @@ class TextLoggerHook(LoggerHook): self.json_log_path = osp.join(self.out_dir, '{}.log.json'.format(trainer.timestamp)) if hasattr(trainer, 'meta') and trainer.meta is not None: - self._dump_log(trainer.meta, trainer) + self._dump_log(trainer.meta) def _get_max_memory(self, trainer): device = getattr(trainer.model, 'output_device', None) diff --git a/modelscope/trainers/trainer.py b/modelscope/trainers/trainer.py index e1fd7522..aaf24cfa 100644 --- a/modelscope/trainers/trainer.py +++ b/modelscope/trainers/trainer.py @@ -183,7 +183,7 @@ class EpochBasedTrainer(BaseTrainer): preprocessor=self.eval_preprocessor, **kwargs) - self.train_data_collator, self.eval_default_collate = None, None + self.train_data_collator, self.eval_data_collator = None, None if isinstance(data_collator, Mapping): if not (ConfigKeys.train in data_collator or ConfigKeys.val in data_collator):