From eb12eb1c8fb28e38b3c4fe2887c2a07e11ef3a9f Mon Sep 17 00:00:00 2001 From: haixuanTao Date: Sat, 2 Mar 2024 17:15:13 +0100 Subject: [PATCH] Fix `clippy` error within `dora-record` within the writing loop --- libraries/extensions/dora-record/src/main.rs | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/libraries/extensions/dora-record/src/main.rs b/libraries/extensions/dora-record/src/main.rs index bb52dc35..17ff8345 100644 --- a/libraries/extensions/dora-record/src/main.rs +++ b/libraries/extensions/dora-record/src/main.rs @@ -77,17 +77,13 @@ async fn main() -> eyre::Result<()> { // Per Input thread let join_handle = tokio::spawn(async move { while let Some((data, metadata)) = rx.recv().await { - match write_event(&mut writer, data, &metadata, schema.clone()) - .await + if let Err(e) = + write_event(&mut writer, data, &metadata, schema.clone()).await { - Err(e) => println!( - "Error writing event data into parquet file: {:?}", - e - ), - _ => (), + println!("Error writing event data into parquet file: {:?}", e) }; } - writer.close() + writer.close().await }); writers.insert(id, (tx, join_handle)); } @@ -111,7 +107,6 @@ async fn main() -> eyre::Result<()> { join_handle .await .context("Writer thread failed")? - .await .context(format!( "Could not close the Parquet writer for {id} parquet writer" ))?;