From cc9eeac472b723534fca69878f4c7f623abb9ba3 Mon Sep 17 00:00:00 2001 From: Chrislearn Young Date: Mon, 7 Jul 2025 18:03:32 +0800 Subject: [PATCH] Made some changes to make clippy happy --- apis/rust/node/src/node/arrow_utils.rs | 4 ++-- apis/rust/node/src/node/mod.rs | 1 + libraries/core/src/descriptor/validate.rs | 2 +- libraries/extensions/telemetry/tracing/src/telemetry.rs | 2 +- node-hub/openai-proxy-server/src/main.rs | 5 +++-- 5 files changed, 8 insertions(+), 6 deletions(-) diff --git a/apis/rust/node/src/node/arrow_utils.rs b/apis/rust/node/src/node/arrow_utils.rs index 247c76ae..5a21337a 100644 --- a/apis/rust/node/src/node/arrow_utils.rs +++ b/apis/rust/node/src/node/arrow_utils.rs @@ -11,7 +11,7 @@ fn required_data_size_inner(array: &ArrayData, next_offset: &mut usize) { for (buffer, spec) in array.buffers().iter().zip(&layout.buffers) { // consider alignment padding if let BufferSpec::FixedWidth { alignment, .. } = spec { - *next_offset = (*next_offset + alignment - 1) / alignment * alignment; + *next_offset = (*next_offset).div_ceil(*alignment) * alignment; } *next_offset += buffer.len(); } @@ -42,7 +42,7 @@ fn copy_array_into_sample_inner( ); // add alignment padding if let BufferSpec::FixedWidth { alignment, .. } = spec { - *next_offset = (*next_offset + alignment - 1) / alignment * alignment; + *next_offset = (*next_offset).div_ceil(*alignment) * alignment; } target_buffer[*next_offset..][..len].copy_from_slice(buffer.as_slice()); diff --git a/apis/rust/node/src/node/mod.rs b/apis/rust/node/src/node/mod.rs index 7b4a109c..0c986ad5 100644 --- a/apis/rust/node/src/node/mod.rs +++ b/apis/rust/node/src/node/mod.rs @@ -44,6 +44,7 @@ mod drop_stream; pub const ZERO_COPY_THRESHOLD: usize = 4096; +#[allow(dead_code)] enum TokioRuntime { Runtime(Runtime), Handle(Handle), diff --git a/libraries/core/src/descriptor/validate.rs b/libraries/core/src/descriptor/validate.rs index f68979cd..da4a3798 100644 --- a/libraries/core/src/descriptor/validate.rs +++ b/libraries/core/src/descriptor/validate.rs @@ -54,7 +54,7 @@ pub fn check_dataflow( }; } }, - dora_message::descriptor::NodeSource::GitBranch { repo, rev } => { + dora_message::descriptor::NodeSource::GitBranch { .. } => { info!("skipping check for node with git source"); } }, diff --git a/libraries/extensions/telemetry/tracing/src/telemetry.rs b/libraries/extensions/telemetry/tracing/src/telemetry.rs index 526fe970..1d4e6772 100644 --- a/libraries/extensions/telemetry/tracing/src/telemetry.rs +++ b/libraries/extensions/telemetry/tracing/src/telemetry.rs @@ -6,7 +6,7 @@ use std::collections::HashMap; struct MetadataMap<'a>(HashMap<&'a str, &'a str>); -impl<'a> Extractor for MetadataMap<'a> { +impl Extractor for MetadataMap<'_> { /// Get a value for a key from the MetadataMap. If the value can't be converted to &str, returns None fn get(&self, key: &str) -> Option<&str> { self.0.get(key).cloned() diff --git a/node-hub/openai-proxy-server/src/main.rs b/node-hub/openai-proxy-server/src/main.rs index 50e73880..4cee442f 100644 --- a/node-hub/openai-proxy-server/src/main.rs +++ b/node-hub/openai-proxy-server/src/main.rs @@ -96,7 +96,7 @@ async fn main() -> eyre::Result<()> { ) .context("failed to send dora output")?; - reply_channels.push_back((reply, 0 as u64, request.model)); + reply_channels.push_back((reply, 0_u64, request.model)); } }, dora_node_api::merged::MergedEvent::Dora(event) => match event { @@ -112,7 +112,7 @@ async fn main() -> eyre::Result<()> { let data = data.as_string::(); let string = data.iter().fold("".to_string(), |mut acc, s| { if let Some(s) = s { - acc.push_str("\n"); + acc.push('\n'); acc.push_str(s); } acc @@ -164,6 +164,7 @@ async fn main() -> eyre::Result<()> { Ok(()) } +#[allow(clippy::large_enum_variant)] enum ServerEvent { Result(eyre::Result<()>), ChatCompletionRequest {