From c87886296676ddd28eff9213d3b09370cbd11bd3 Mon Sep 17 00:00:00 2001 From: haixuanTao Date: Thu, 25 Jan 2024 13:52:33 +0100 Subject: [PATCH] Use forward slash as it is default way of defining ros2 topic --- examples/python-ros2-dataflow/random_turtle.py | 6 ++---- libraries/extensions/ros2-bridge/python/src/lib.rs | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/examples/python-ros2-dataflow/random_turtle.py b/examples/python-ros2-dataflow/random_turtle.py index 3e97228b..e6fa2c75 100755 --- a/examples/python-ros2-dataflow/random_turtle.py +++ b/examples/python-ros2-dataflow/random_turtle.py @@ -21,14 +21,12 @@ topic_qos = dora.experimental.ros2_bridge.Ros2QosPolicies( # Create a publisher to cmd_vel topic turtle_twist_topic = ros2_node.create_topic( - "/turtle1/cmd_vel", "geometry_msgs::Twist", topic_qos + "/turtle1/cmd_vel", "geometry_msgs/Twist", topic_qos ) twist_writer = ros2_node.create_publisher(turtle_twist_topic) # Create a listener to pose topic -turtle_pose_topic = ros2_node.create_topic( - "/turtle1/pose", "turtlesim::Pose", topic_qos -) +turtle_pose_topic = ros2_node.create_topic("/turtle1/pose", "turtlesim/Pose", topic_qos) pose_reader = ros2_node.create_subscription(turtle_pose_topic) # Create a dora node diff --git a/libraries/extensions/ros2-bridge/python/src/lib.rs b/libraries/extensions/ros2-bridge/python/src/lib.rs index 9d06bbaf..f072ceb8 100644 --- a/libraries/extensions/ros2-bridge/python/src/lib.rs +++ b/libraries/extensions/ros2-bridge/python/src/lib.rs @@ -101,7 +101,7 @@ impl Ros2Node { message_type: String, qos: qos::Ros2QosPolicies, ) -> eyre::Result { - let (namespace_name, message_name) = message_type.split_once("::").with_context(|| { + let (namespace_name, message_name) = message_type.split_once("/").with_context(|| { format!( "message type must be of form `package::type`, is `{}`", message_type