From a88196e331b2c57a6ddcdba5202c6286df138371 Mon Sep 17 00:00:00 2001
From: Shar-jeel-Sajid <sharjeelsajid09@gmail.com>
Date: Thu, 20 Mar 2025 07:58:16 +0500
Subject: [PATCH] linting and renaming

---
 libraries/arrow-convert/src/lib.rs | 2 +-
 node-hub/dora-rerun/src/series.rs  | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/libraries/arrow-convert/src/lib.rs b/libraries/arrow-convert/src/lib.rs
index c2a4d7c3..0c405403 100644
--- a/libraries/arrow-convert/src/lib.rs
+++ b/libraries/arrow-convert/src/lib.rs
@@ -31,7 +31,7 @@ impl DerefMut for ArrowData {
 
 macro_rules! register_array_handlers {
     ($(($variant:path, $array_type:ty, $type_name:expr)),* $(,)?) => {
-        pub fn cast_values(data: &ArrowData) -> Result<Vec<f64>> {
+        pub fn into_vec_f64(data: &ArrowData) -> Result<Vec<f64>> {
             match data.data_type() {
                 $(
                     $variant => {
diff --git a/node-hub/dora-rerun/src/series.rs b/node-hub/dora-rerun/src/series.rs
index cd561316..5b5f8b2b 100644
--- a/node-hub/dora-rerun/src/series.rs
+++ b/node-hub/dora-rerun/src/series.rs
@@ -1,15 +1,13 @@
 use dora_node_api::{
-    arrow::array::{Float32Array, Float64Array, Int32Array, Int64Array, UInt32Array},
-    arrow::datatypes::DataType,
-    cast_values,
+    into_vec_f64,
     dora_core::config::DataId,
     ArrowData,
 };
-use eyre::{Context, ContextCompat, Result};
+use eyre::{Context, Result};
 use rerun::RecordingStream;
 
 pub fn update_series(rec: &RecordingStream, id: DataId, data: ArrowData) -> Result<()> {
-    let series = cast_values(&data).context("could not cast values")?;
+    let series = into_vec_f64(&data).context("could not cast values")?;
     for (i, value) in series.iter().enumerate() {
         rec.log(
             format!("{}_{}", id.as_str(), i),