From 77c277910b0ce87b902faa1ab369a33cbcd555f4 Mon Sep 17 00:00:00 2001 From: Philipp Oppermann Date: Wed, 30 Jul 2025 17:28:05 +0200 Subject: [PATCH] Add a MSRV CI job (#1094) * Add a MSVR CI job Check that we don't use features that are only available on newer Rust versions. * Add `rust-version` field to node hub packages * Exclude `dora-rav1e` in `msrv` test job * Add a name for the msrv job * Exclude `dora-dav1d` in `msrv` test job --- .github/workflows/ci.yml | 9 +++++++++ node-hub/dora-dav1d/Cargo.toml | 1 + node-hub/dora-mistral-rs/Cargo.toml | 1 + 3 files changed, 11 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 27d0441b..34e26dda 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -546,3 +546,12 @@ jobs: use-cross: true command: check args: --target ${{ matrix.platform.target }} --all --exclude dora-dav1d --exclude dora-rav1e --exclude dora-node-api-python --exclude dora-operator-api-python --exclude dora-ros2-bridge-python + + # copied from https://github.com/rust-lang/cargo/blob/6833aa715d724437dc1247d0166afe314ab6854e/.github/workflows/main.yml#L291 + msrv: + name: "Check for specified `rust-version`" + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: taiki-e/install-action@cargo-hack + - run: cargo hack check --all-targets --rust-version --workspace --ignore-private --locked --exclude dora-rav1e --exclude dora-dav1d diff --git a/node-hub/dora-dav1d/Cargo.toml b/node-hub/dora-dav1d/Cargo.toml index 5b925ce0..cece10d2 100644 --- a/node-hub/dora-dav1d/Cargo.toml +++ b/node-hub/dora-dav1d/Cargo.toml @@ -3,6 +3,7 @@ name = "dora-dav1d" edition.workspace = true license = "BSD-2-Clause" version.workspace = true +rust-version.workspace = true # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html diff --git a/node-hub/dora-mistral-rs/Cargo.toml b/node-hub/dora-mistral-rs/Cargo.toml index be561a1a..bb063b4d 100644 --- a/node-hub/dora-mistral-rs/Cargo.toml +++ b/node-hub/dora-mistral-rs/Cargo.toml @@ -2,6 +2,7 @@ name = "dora-mistral-rs" version = "0.1.0" edition = "2024" +rust-version.workspace = true # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html