From 56012d62ddf4c4bc02308b896d8e8cf6abf37e3c Mon Sep 17 00:00:00 2001 From: Weijun Lee <99924265+wlee-fw@users.noreply.github.com> Date: Thu, 23 Feb 2023 15:01:05 -0600 Subject: [PATCH 1/5] Update LICENSE (#186) Edit line 189: Copyright [2022] [Futurewei Technologies Inc.] --- LICENSE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/LICENSE b/LICENSE index 261eeb9e..7b2796d5 100644 --- a/LICENSE +++ b/LICENSE @@ -186,7 +186,7 @@ same "printed page" as the copyright notice for easier identification within third-party archives. - Copyright [yyyy] [name of copyright owner] + Copyright [2022] [Futurewei Technologies Inc.] Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. From cede79608894d27b2d30066d2654c9eb5e9294b0 Mon Sep 17 00:00:00 2001 From: Yong He <45980096+heyong4725@users.noreply.github.com> Date: Thu, 23 Feb 2023 17:39:55 -0600 Subject: [PATCH 2/5] Update License / copyright section --- LICENSE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/LICENSE b/LICENSE index 7b2796d5..0ca07453 100644 --- a/LICENSE +++ b/LICENSE @@ -186,7 +186,7 @@ same "printed page" as the copyright notice for easier identification within third-party archives. - Copyright [2022] [Futurewei Technologies Inc.] + Copyright [2022] [All content is the property of the respective authors or their employers. For more information regarding authorship of content, please consult the listed source code repository logs.] Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. From a954fdf58d9fe6239a3ca1ce931d78f12ad4ed1d Mon Sep 17 00:00:00 2001 From: Yong He <45980096+heyong4725@users.noreply.github.com> Date: Thu, 23 Feb 2023 17:43:53 -0600 Subject: [PATCH 3/5] Update License/copyright section --- LICENSE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/LICENSE b/LICENSE index 0ca07453..fe9751aa 100644 --- a/LICENSE +++ b/LICENSE @@ -186,7 +186,7 @@ same "printed page" as the copyright notice for easier identification within third-party archives. - Copyright [2022] [All content is the property of the respective authors or their employers. For more information regarding authorship of content, please consult the listed source code repository logs.] + Copyright [2022] [The Dora-rs Authors] Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. From 1cd6fd7038dafad26f6aed15b2c649de777589f9 Mon Sep 17 00:00:00 2001 From: Haixuan Xavier Tao Date: Fri, 24 Feb 2023 11:55:56 +0100 Subject: [PATCH 4/5] Update issue templates (#189) * Update issue templates Those issue template will help us have better issues and feature requests. * Add better reproduce template and version check of dora --- .github/ISSUE_TEMPLATE/bug_report.md | 31 +++++++++++++++++++++++ .github/ISSUE_TEMPLATE/feature_request.md | 20 +++++++++++++++ 2 files changed, 51 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md create mode 100644 .github/ISSUE_TEMPLATE/feature_request.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 00000000..ef4c0abb --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,31 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: '' +assignees: '' + +--- + +**Describe the bug** +A clear and concise description of what the bug is. + +**To Reproduce** +Steps to reproduce the behavior: +1. Dora start daemon: `dora up` +2. Start a new dataflow: `dora start dataflow.yaml` +3. Stop dataflow: `dora stop` +4. Destroy dataflow: `dora destroy` + +**Expected behavior** +A clear and concise description of what you expected to happen. + +**Screenshots or Video** +If applicable, add screenshots to help explain your problem. + +**Environments (please complete the following information):** + - System info: [use `uname --all` on LInux] + - Dora version [use `dora --version` and `pip show dora-rs`] + +**Additional context** +Add any other context about the problem here. diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 00000000..bbcbbe7d --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,20 @@ +--- +name: Feature request +about: Suggest an idea for this project +title: '' +labels: '' +assignees: '' + +--- + +**Is your feature request related to a problem? Please describe.** +A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] + +**Describe the solution you'd like** +A clear and concise description of what you want to happen. + +**Describe alternatives you've considered** +A clear and concise description of any alternative solutions or features you've considered. + +**Additional context** +Add any other context or screenshots about the feature request here. From 6d90817284bb5afdae1fc198b3315869d5098303 Mon Sep 17 00:00:00 2001 From: Philipp Oppermann Date: Mon, 6 Mar 2023 08:59:21 +0100 Subject: [PATCH 5/5] Simplify: Replace `library_filename` function with `format!` call --- examples/c++-dataflow/run.rs | 13 +------------ examples/c-dataflow/run.rs | 13 +------------ 2 files changed, 2 insertions(+), 24 deletions(-) diff --git a/examples/c++-dataflow/run.rs b/examples/c++-dataflow/run.rs index b76c52d3..5ce1a681 100644 --- a/examples/c++-dataflow/run.rs +++ b/examples/c++-dataflow/run.rs @@ -257,7 +257,7 @@ async fn build_cxx_operator( link.arg("-fms-runtime-lib=static"); } link.arg("-o") - .arg(Path::new("../build").join(library_filename(out_name))); + .arg(Path::new("../build").join(format!("{DLL_PREFIX}{out_name}{DLL_SUFFIX}"))); if let Some(parent) = paths[0].parent() { link.current_dir(parent); } @@ -267,14 +267,3 @@ async fn build_cxx_operator( Ok(()) } - -// taken from `rust_libloading` crate by Simonas Kazlauskas, licensed under the ISC license ( -// see https://github.com/nagisa/rust_libloading/blob/master/LICENSE) -pub fn library_filename>(name: S) -> OsString { - let name = name.as_ref(); - let mut string = OsString::with_capacity(name.len() + DLL_PREFIX.len() + DLL_SUFFIX.len()); - string.push(DLL_PREFIX); - string.push(name); - string.push(DLL_SUFFIX); - string -} diff --git a/examples/c-dataflow/run.rs b/examples/c-dataflow/run.rs index 724729fc..31fddd38 100644 --- a/examples/c-dataflow/run.rs +++ b/examples/c-dataflow/run.rs @@ -117,21 +117,10 @@ async fn build_c_operator() -> eyre::Result<()> { let mut link = tokio::process::Command::new("clang"); link.arg("-shared").arg("build/operator.o"); link.arg("-o") - .arg(Path::new("build").join(library_filename("operator"))); + .arg(Path::new("build").join(format!("{DLL_PREFIX}operator{DLL_SUFFIX}"))); if !link.status().await?.success() { bail!("failed to link c operator"); }; Ok(()) } - -// taken from `rust_libloading` crate by Simonas Kazlauskas, licensed under the ISC license ( -// see https://github.com/nagisa/rust_libloading/blob/master/LICENSE) -pub fn library_filename>(name: S) -> OsString { - let name = name.as_ref(); - let mut string = OsString::with_capacity(name.len() + DLL_PREFIX.len() + DLL_SUFFIX.len()); - string.push(DLL_PREFIX); - string.push(name); - string.push(DLL_SUFFIX); - string -}