From 20bd282e096653a5a9f609f54138044e7a72f87b Mon Sep 17 00:00:00 2001
From: Shar-jeel-Sajid <sharjeelsajid09@gmail.com>
Date: Wed, 19 Mar 2025 17:24:43 +0500
Subject: [PATCH] tried adding macro

---
 node-hub/dora-rerun/src/series.rs | 94 +++++++++++--------------------
 1 file changed, 34 insertions(+), 60 deletions(-)

diff --git a/node-hub/dora-rerun/src/series.rs b/node-hub/dora-rerun/src/series.rs
index 7b65452d..8a88bfe7 100644
--- a/node-hub/dora-rerun/src/series.rs
+++ b/node-hub/dora-rerun/src/series.rs
@@ -1,71 +1,45 @@
 use dora_node_api::{
-    arrow::array::{Float32Array, Float64Array, Int32Array, Int64Array},
+    arrow::array::{Float32Array, Float64Array, Int32Array, Int64Array, UInt32Array},
+    arrow::datatypes::DataType,
     dora_core::config::DataId,
     ArrowData,
 };
 use eyre::{Context, ContextCompat, Result};
 use rerun::RecordingStream;
 
-pub fn update_series(rec: &RecordingStream, id: DataId, data: ArrowData) -> Result<()> {
-    match data.data_type() {
-        dora_node_api::arrow::datatypes::DataType::Float32 => {
-            let buffer: &Float32Array = data
-                .as_any()
-                .downcast_ref()
-                .context("series is not float32")?;
-            let series: Vec<_> = buffer.values().to_vec();
-            for (i, value) in series.iter().enumerate() {
-                rec.log(
-                    format!("{}_{}", id.as_str(), i),
-                    &rerun::Scalar::new(*value as f64),
-                )
-                .wrap_err("could not log series")?;
-            }
-        }
-        dora_node_api::arrow::datatypes::DataType::Float64 => {
-            let buffer: &Float64Array = data
-                .as_any()
-                .downcast_ref()
-                .context("series is not float64")?;
-            let series: Vec<_> = buffer.values().to_vec();
-            for (i, value) in series.iter().enumerate() {
-                rec.log(
-                    format!("{}_{}", id.as_str(), i),
-                    &rerun::Scalar::new(*value),
-                )
-                .wrap_err("could not log series")?;
-            }
-        }
-        dora_node_api::arrow::datatypes::DataType::Int32 => {
-            let buffer: &Int32Array = data
-                .as_any()
-                .downcast_ref()
-                .context("series is not Int32")?;
-            let series: Vec<_> = buffer.values().to_vec();
-            for (i, value) in series.iter().enumerate() {
-                rec.log(
-                    format!("{}_{}", id.as_str(), i),
-                    &rerun::Scalar::new(*value as f64),
-                )
-                .wrap_err("could not log series")?;
-            }
-        }
-        dora_node_api::arrow::datatypes::DataType::Int64 => {
-            let buffer: &Int64Array = data
-                .as_any()
-                .downcast_ref()
-                .context("series is not Int64")?;
-            let series: Vec<_> = buffer.values().to_vec();
-            for (i, value) in series.iter().enumerate() {
-                rec.log(
-                    format!("{}_{}", id.as_str(), i),
-                    &rerun::Scalar::new(*value as f64),
-                )
-                .wrap_err("could not log series")?;
+macro_rules! register_array_handlers {
+    ($(($variant:path, $array_type:ty, $type_name:expr)),* $(,)?) => {
+        pub fn update_series(rec: &RecordingStream, id: DataId, data: ArrowData) -> Result<()> {
+            match data.data_type() {
+                $(
+                    $variant => {
+                        let buffer: &$array_type = data
+                            .as_any()
+                            .downcast_ref()
+                            .context(concat!("series is not ", $type_name))?;
+                        let series: Vec<_> = buffer.values().to_vec();
+                        for (i, value) in series.iter().enumerate() {
+                            rec.log(
+                                format!("{}_{}", id.as_str(), i),
+                                &rerun::Scalar::new(*value as f64),
+                            )
+                            .wrap_err("could not log series")?;
+                        }
+                    }
+                ),*
+                _ => unimplemented!("This has not yet implemented. Please contribute to dora-rerun :)"),
             }
+            Ok(())
         }
+    };
+}
 
-        _ => unimplemented!("This has not yet implemented. Please contribute to dora-rerun :)"),
-    }
-    Ok(())
+// Register all supported array types in one place
+register_array_handlers! {
+    (DataType::Float32, Float32Array, "float32"),
+    (DataType::Float64, Float64Array, "float64"),
+    (DataType::Int32, Int32Array, "int32"),
+    (DataType::Int64, Int64Array, "int64"),
+    // Add new types here easily:
+    (DataType::UInt32, UInt32Array, "uint32"),
 }