From 15bbacc3d950dbf815cce4d2a25cb5c7a466349f Mon Sep 17 00:00:00 2001
From: Michael-J-Ward <ward.michael.j@gmail.com>
Date: Tue, 13 Aug 2024 15:37:24 -0500
Subject: [PATCH] fix clippy lints in binaries

---
 binaries/coordinator/src/lib.rs | 2 +-
 binaries/daemon/src/spawn.rs    | 2 +-
 binaries/runtime/src/lib.rs     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/binaries/coordinator/src/lib.rs b/binaries/coordinator/src/lib.rs
index 88e57290..cdab624a 100644
--- a/binaries/coordinator/src/lib.rs
+++ b/binaries/coordinator/src/lib.rs
@@ -643,7 +643,7 @@ fn dataflow_result(
     clock: &uhlc::HLC,
 ) -> DataflowResult {
     let mut node_results = BTreeMap::new();
-    for (_machine, result) in results {
+    for result in results.values() {
         node_results.extend(result.node_results.clone());
         if let Err(err) = clock.update_with_timestamp(&result.timestamp) {
             tracing::warn!("failed to update HLC: {err}");
diff --git a/binaries/daemon/src/spawn.rs b/binaries/daemon/src/spawn.rs
index 0a0243e2..78302f0d 100644
--- a/binaries/daemon/src/spawn.rs
+++ b/binaries/daemon/src/spawn.rs
@@ -210,7 +210,7 @@ pub async fn spawn_node(
                     command.args([
                         "run",
                         "-n",
-                        &conda_env,
+                        conda_env,
                         "python",
                         "-c",
                         format!("import dora; dora.start_runtime() # {}", node.id).as_str(),
diff --git a/binaries/runtime/src/lib.rs b/binaries/runtime/src/lib.rs
index 22b81f50..c54d4317 100644
--- a/binaries/runtime/src/lib.rs
+++ b/binaries/runtime/src/lib.rs
@@ -37,7 +37,7 @@ pub fn main() -> eyre::Result<()> {
     } = config;
     let node_id = config.node_id.clone();
     #[cfg(feature = "tracing")]
-    set_up_tracing(&node_id.to_string()).context("failed to set up tracing subscriber")?;
+    set_up_tracing(node_id.as_ref()).context("failed to set up tracing subscriber")?;
 
     let dataflow_descriptor = config.dataflow_descriptor.clone();