Browse Source

[FIX] fix details

tags/v0.3.2
Gene 2 years ago
parent
commit
de0ce05613
3 changed files with 14 additions and 15 deletions
  1. +0
    -1
      learnware/client/container.py
  2. +4
    -4
      learnware/client/learnware_client.py
  3. +10
    -10
      tests/test_learnware_client/test_check_learnware.py

+ 0
- 1
learnware/client/container.py View File

@@ -561,7 +561,6 @@ class LearnwaresContainer:
return self

def __exit__(self, exc_type, exc_val, exc_tb):
return # TODO
if not self.cleanup:
logger.warning(f"Notice, the learnware container env is not cleaned up!")
self.learnware_containers = None


+ 4
- 4
learnware/client/learnware_client.py View File

@@ -178,7 +178,7 @@ class LearnwareClient:
headers=self.headers,
stream=True,
)
print(response)
if response.status_code != 200:
raise Exception("download failed: " + json.dumps(response.json()))

@@ -247,7 +247,7 @@ class LearnwareClient:

for learnware in result["data"]["learnware_list_single"]:
returns.append(
{
{
"type": "single",
"learnware_id": learnware["learnware_id"],
"semantic_specification": learnware["semantic_specification"],
@@ -259,12 +259,12 @@ class LearnwareClient:
"type": "multiple",
"learnware_ids": [],
"semantic_specifications": [],
"matching": result["data"]["learnware_list_multi"][0]["matching"]
"matching": result["data"]["learnware_list_multi"][0]["matching"],
}
for learnware in result["data"]["learnware_list_multi"]:
multiple_learnware["learnware_ids"].append(learnware["learnware_id"])
multiple_learnware["semantic_specifications"].append(learnware["semantic_specification"])
returns.append(multiple_learnware)
return returns



+ 10
- 10
tests/test_learnware_client/test_check_learnware.py View File

@@ -46,16 +46,16 @@ class TestCheckLearnware(unittest.TestCase):
semantic_spec = json.load(json_file)
LearnwareClient.check_learnware(self.zip_path, semantic_spec)

def test_check_learnware_image(self):
learnware_id = "00000677"
with tempfile.TemporaryDirectory(prefix="learnware_") as tempdir:
self.zip_path = os.path.join(tempdir, "test.zip")
self.client.download_learnware(learnware_id, self.zip_path)
with zipfile.ZipFile(self.zip_path, "r") as zip_file:
with zip_file.open("semantic_specification.json") as json_file:
semantic_spec = json.load(json_file)
LearnwareClient.check_learnware(self.zip_path, semantic_spec)
# def test_check_learnware_image(self):
# learnware_id = "00000677"
# with tempfile.TemporaryDirectory(prefix="learnware_") as tempdir:
# self.zip_path = os.path.join(tempdir, "test.zip")
# self.client.download_learnware(learnware_id, self.zip_path)
# with zipfile.ZipFile(self.zip_path, "r") as zip_file:
# with zip_file.open("semantic_specification.json") as json_file:
# semantic_spec = json.load(json_file)
# LearnwareClient.check_learnware(self.zip_path, semantic_spec)

def test_check_learnware_text(self):
learnware_id = "00000662"


Loading…
Cancel
Save