OpenBLAS

Tree: d117dfd505

History

Jehan 1f6071590d Fix usage of TerminateThread() causing critical section corruption. This patch was submitted to the GIMP project by a publisher wishing to keep confidentiality (hence anonymously). I just pass along the patch. Here is the patch explanation which came with: First they remind us what Microsoft documentation says about TerminateThread: > TerminateThread is a dangerous function that should only be used in > the most extreme cases. You should call TerminateThread only if you > know exactly what the target thread is doing, and you control all of > the code that the target thread could possibly be running at the time > of the termination. (https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-terminatethread) Then they say that 5 milliseconds time-out might not be long enough for the thread to exit gracefully. They propose to set it to a much higher value (for instance here 5 seconds). And finally you should always check the return value of WaitForSingleObject(). In particular you want to run TerminateThread() only if WaitForSingleObject() failed, not on success case.		6 years ago
..
level2	Revert "Avoid taking root of negative number in symv_thread.c"	6 years ago

level3	Avoid taking the root of a negative number	7 years ago

mapper	Remove all trailing whitespace except lapack-netlib	11 years ago

others	Fix usage of TerminateThread() causing critical section corruption.	6 years ago

OpenBLAS is an optimized BLAS library based on GotoBLAS2 1.13 BSD version.

C Fortran Motorola 68K Assembly Makefile Unix Assembly other

martin@ruby.chemie.uni-freiburg.de traits.zhang@gmail.com wernsaar@googlemail.com xianyi@iscas.ac.cn hank.p.anderson@gmail.com ashwin.sekhar@cavium.com isuruf@gmail.com wangqian10@iscas.ac.cn arjan@linux.intel.com m.tk1@hotmail.com 16061801+brada4@users.noreply.github.com ashwin@broadcom.com 52632443+wjc404@users.noreply.github.com bradatajs@yahoo.com jeromerobert@gmx.com zaheer.chothia@gmail.com quickwritereader@gmail.com guillaume.horel@gmail.com kirkhamj@janelia.hhmi.org shivraj.patil@imgtec.com gyori.tibor@stud.u-szeged.hu koehlerm@mpi-magdeburg.mpg.de ararslan@comcast.net xsacha@gmail.com timothygu99@gmail.com