* With the Intel compiler on Linux, prefer ifort for the final link step
icc has known problems with mixed-language builds that ifort can handle just fine. Fixes#1956
* Rename operands to put lda on the input/output constraint list
* Fix wrong constraints in inline assembly
for #2009
* Fix inline assembly constraints
rework indices to allow marking argument lda4 as input and output. For #2009
* Fix inline assembly constraints
rework indices to allow marking argument lda as input and output.
* Fix inline assembly constraints
* Fix inline assembly constraints
* Fix inline assembly constraints in Bulldozer TRSM kernels
rework indices to allow marking i,as and bs as both input and output (marked operand n1 as well for simplicity). For #2009
* Correct range_n limiting
same bug as seen in #1388, somehow missed in corresponding PR #1389
* Allow multithreading TRMV again
revert workaround introduced for issue #1332 as the actual cause appears to be my incorrect fix from #1262 (see #1388)
* Fix error introduced during cleanup
* Reduce list of kernels in the dynamic arch build
to make compilation complete reliably within the 1h limit again
* init
* move fix to right place
* Fix missing -c option in AVX512 test
* Fix AVX512 test always returning false due to missing compiler option
* Make x86_32 imply NO_AVX2, NO_AVX512 in addition to NO_AVX
fixes#2033
* Keep xcode8.3 for osx BINARY=32 build
as xcode10 deprecated i386
* Make sure that AVX512 is disabled in 32bit builds
for #2033
* Improve handling of NO_STATIC and NO_SHARED
to avoid surprises from defining either as zero. Fixes#2035 by addressing some concerns from #1422
* init
* address warning introed with #1814 et al
* Restore locking optimizations for OpenMP case
restore another accidentally dropped part of #1468 that was missed in #2004 to address performance regression reported in #1461
* HiSilicon tsv110 CPUs optimization branch
add HiSilicon tsv110 CPUs optimization branch
* add TARGET support for HiSilicon tsv110 CPUs
* add TARGET support for HiSilicon tsv110 CPUs
* add TARGET support for HiSilicon tsv110 CPUs
* Fix module definition conflicts between LAPACK and ReLAPACK
for #2043
* Do not compile in AVX512 check if AVX support is disabled
xgetbv is function depends on NO_AVX being undefined - we could change that too, but that combo is unlikely to work anyway
* ctest.c : add __POWERPC__ for PowerMac
* Fix crash in sgemm SSE/nano kernel on x86_64
Fix bug #2047.
Signed-off-by: Celelibi <celelibi@gmail.com>
* param.h : enable defines for PPC970 on DarwinOS
fixes:
gemm.c: In function 'sgemm_':
../common_param.h:981:18: error: 'SGEMM_DEFAULT_P' undeclared (first use in this function)
#define SGEMM_P SGEMM_DEFAULT_P
^
* common_power.h: force DCBT_ARG 0 on PPC970 Darwin
without this, we see
../kernel/power/gemv_n.S:427:Parameter syntax error
and many more similar entries
that relates to this assembly command
dcbt 8, r24, r18
this change makes the DCBT_ARG = 0
and openblas builds through to completion on PowerMac 970
Tests pass
* Make TARGET=GENERIC compatible with DYNAMIC_ARCH=1
for issue #2048
* make DYNAMIC_ARCH=1 package work on TSV110.
* make DYNAMIC_ARCH=1 package work on TSV110
* Add Intel Denverton
for #2048
* Add Intel Denverton
* Change 64-bit detection as explained in #2056
* Trivial typo fix
as suggested in #2022
* Disable the AVX512 DGEMM kernel (again)
Due to as yet unresolved errors seen in #1955 and #2029
* Use POSIX getenv on Cygwin
The Windows-native GetEnvironmentVariable cannot be relied on, as
Cygwin does not always copy environment variables set through Cygwin
to the Windows environment block, particularly after fork().
* Fix for #2063: The DllMain used in Cygwin did not run the thread memory
pool cleanup upon THREAD_DETACH which is needed when compiled with
USE_TLS=1.
* Also call CloseHandle on each thread, as well as on the event so as to not leak thread handles.
* AIX asm syntax changes needed for shared object creation
* power9 makefile. dgemm based on power8 kernel with following changes : 32x unrolled 16x4 kernel and 8x4 kernel using (lxv stxv butterfly rank1 update). improvement from 17 to 22-23gflops. dtrmm cases were added into dgemm itself
* Expose CBLAS interfaces for I?MIN and I?MAX
* Build CBLAS interfaces for I?MIN and I?MAX
* Add declarations for ?sum and cblas_?sum
* Add interface for ?sum (derived from ?asum)
* Add ?sum
* Add implementations of ssum/dsum and csum/zsum
as trivial copies of asum/zsasum with the fabs calls replaced by fmov to preserve code structure
* Add ARM implementations of ?sum
(trivial copies of the respective ?asum with the fabs calls removed)
* Add ARM64 implementations of ?sum
as trivial copies of the respective ?asum kernels with the fabs calls removed
* Add ia64 implementation of ?sum
as trivial copy of asum with the fabs calls removed
* Add MIPS implementation of ?sum
as trivial copy of ?asum with the fabs calls removed
* Add MIPS64 implementation of ?sum
as trivial copy of ?asum with the fabs replaced by mov to preserve code structure
* Add POWER implementation of ?sum
as trivial copy of ?asum with the fabs replaced by fmr to preserve code structure
* Add SPARC implementation of ?sum
as trivial copy of ?asum with the fabs replaced by fmov to preserve code structure
* Add x86 implementation of ?sum
as trivial copy of ?asum with the fabs calls removed
* Add x86_64 implementation of ?sum
as trivial copy of ?asum with the fabs calls removed
* Add ZARCH implementation of ?sum
as trivial copies of the respective ?asum kernels with the ABS and vflpsb calls removed
* Detect 32bit environment on 64bit ARM hardware
for #2056, using same approach as #2058
* Add cmake defaults for ?sum kernels
* Add ?sum
* Add ?sum definitions for generic kernel
* Add declarations for ?sum
* Add -lm and disable EXPRECISION support on *BSD
fixes#2075
* Add in runtime CPU detection for POWER.
* snprintf define consolidated to common.h
* Support INTERFACE64=1
* Add support for INTERFACE64 and fix XERBLA calls
1. Replaced all instances of "int" with "blasint"
2. Added string length as "hidden" third parameter in calls to fortran XERBLA
* Correct length of name string in xerbla call
* Avoid out-of-bounds accesses in LAPACK EIG tests
see https://github.com/Reference-LAPACK/lapack/issues/333
* Correct INFO=4 condition
* Disable reallocation of work array in xSYTRF
as it appears to cause memory management problems (seen in the LAPACK tests)
* Disable repeated recursion on Ab_BR in ReLAPACK xGBTRF
due to crashes in LAPACK tests
* sgemm/strmm
* Update Changelog with changes from 0.3.6
* Increment version to 0.3.7.dev
* Increment version to 0.3.7.dev
* Misc. typo fixes
Found via `codespell -q 3 -w -L ith,als,dum,nd,amin,nto,wis,ba -S ./relapack,./kernel,./lapack-netlib`
* Correct argument of CPU_ISSET for glibc <2.5
fixes#2104
* conflict resolve
* Revert reference/ fixes
* Revert Changelog.txt typos
* Disable the SkyLakeX DGEMMITCOPY kernel as well
as a stopgap measure for https://github.com/numpy/numpy/issues/13401 as mentioned in #1955
* Disable DGEMMINCOPY as well for now
#1955
* init
* Fix errors in cpu enumeration with glibc 2.6
for #2114
* Change two http links to https
Closes#2109
* remove redundant code #2113
* Set up CI with Azure Pipelines
[skip ci]
* TST: add native POWER8 to CI
* add native POWER8 testing to
Travis CI matrix with ppc64le
os entry
* Update link to IBM MASS library, update cpu support status
* first try migrating one of the arm builds from travis
* fix tabbing in azure commands
* Update azure-pipelines.yml
take out offending lines (although stolen from https://github.com/conda-forge/opencv-feedstock azure-pipelines fiie)
* Update azure-pipelines.yml
* Update azure-pipelines.yml
* Update azure-pipelines.yml
* Update azure-pipelines.yml
* DOC: Add Azure CI status badge
* Add ARMV6 build to azure CI setup (#2122)
using aytekinar's Alpine image and docker script from the Travis setup
[skip ci]
* TST: Azure manylinux1 & clean-up
* remove some of the steps & comments
from the original Azure yml template
* modify the trigger section to use
develop since OpenBLAS primarily uses
this branch; use the same batching
behavior as downstream projects NumPy/
SciPy
* remove Travis emulated ARMv6 gcc build
because this now happens in Azure
* use documented Ubuntu vmImage name for Azure
and add in a manylinux1 test run to the matrix
[skip appveyor]
* Add NO_AFFINITY to available options on Linux, and set it to ON
to match the gmake default. Fixes second part of #2114
* Replace ISMIN and ISAMIN kernels on all x86_64 platforms (#2125)
* Mark iamax_sse.S as unsuitable for MIN due to issue #2116
* Use iamax.S rather than iamax_sse.S for ISMIN/ISAMIN on all x86_64 as workaround for #2116
* Move ARMv8 gcc build from Travis to Azure
* Move ARMv8 gcc build from Travis to Azure
* Update .travis.yml
* Test drone CI
* install make
* remove sudo
* Install gcc
* Install perl
* Install gfortran and add a clang job
* gfortran->gcc-gfortran
* Switch to ubuntu and parallel jobs
* apt update
* Fix typo
* update yes
* no need of gcc in clang build
* Add a cmake build as well
* Add cmake builds and print options
* build without lapack on cmake
* parallel build
* See if ubuntu 19.04 fixes the ICE
* Remove qemu armv8 builds
* arm32 build
* Fix typo
* TST: add SkylakeX AVX512 CI test
* adapt the C-level reproducer code for some
recent SkylakeX AVX512 kernel issues, provided
by Isuru Fernando and modified by Martin Kroeker,
for usage in the utest suite
* add an Intel SDE SkylakeX emulation utest run to
the Azure CI matrix; a custom Docker build was required
because Ubuntu image provided by Azure does not support
AVX512VL instructions
* Add option USE_LOCKING for single-threaded build with locking support
for calling from concurrent threads
* Add option USE_LOCKING for single-threaded build with locking support
* Add option USE_LOCKING for SMP-like locking in USE_THREAD=0 builds
* Add option USE_LOCKING but keep default settings intact
* Remove unrelated change
* Do not try ancient PGI hacks with recent versions of that compiler
should fix#2139
* Build and run utests in any case, they do their own checks for fortran availability
* Add softfp support in min/max kernels
fix for #1912
* Revert "Add softfp support in min/max kernels"
* Separate implementations of AMAX and IAMAX on arm
As noted in #1912 and comment on #1942, the combined implementation happens to "do the right thing" on hardfp, but cannot return both value and index on softfp where they would have to share the return register
* Ensure correct output for DAMAX with softfp
* Use generic kernels for complex (I)AMAX to support softfp
* improved zgemm power9 based on power8
* upload thread safety test folder
* hook up c++ thread safety test (main Makefile)
* add c++ thread test option to Makefile.rule
* Document NO_AVX512
for #2151
* sgemm pipeline improved, zgemm rewritten without inner packs, ABI lxvx v20 fixed with vs52
* Fix detection of AVX512 capable compilers in getarch
21eda8b5 introduced a check in getarch.c to test if the compiler is capable of
AVX512. This check currently fails, since the used __AVX2__ macro is only
defined if getarch itself was compiled with AVX2/AVX512 support. Make sure this
is the case by building getarch with -march=native on x86_64. It is only
supposed to run on the build host anyway.
* c_check: Unlink correct file
* power9 zgemm ztrmm optimized
* conflict resolve
* Add gfortran workaround for ABI violations in LAPACKE
for #2154 (see gcc bug 90329)
* Add gfortran workaround for ABI violations
for #2154 (see gcc bug 90329)
* Add gfortran workaround for potential ABI violation
for #2154
* Update fc.cmake
* Remove any inadvertent use of -march=native from DYNAMIC_ARCH builds
from #2143, -march=native precludes use of more specific options like -march=skylake-avx512 in individual kernels, and defeats the purpose of dynamic arch anyway.
* Avoid unintentional activation of TLS code via USE_TLS=0
fixes#2149
* Do not force gcc options on non-gcc compilers
fixes compile failure with pgi 18.10 as reported on OpenBLAS-users
* Update Makefile.x86_64
* Zero ecx with a mov instruction
PGI assembler does not like the initialization in the constraints.
* Fix mov syntax
* new sgemm 8x16
* Update dtrmm_kernel_16x4_power8.S
* PGI compiler does not like -march=native
* Fix build on FreeBSD/powerpc64.
Signed-off-by: Piotr Kubaj <pkubaj@anongoth.pl>
* Fix build for PPC970 on FreeBSD pt. 1
FreeBSD needs DCBT_ARG=0 as well.
* Fix build for PPC970 on FreeBSD pt.2
FreeBSD needs those macros too.
* cgemm/ctrmm power9
* Utest needs CBLAS but not necessarily FORTRAN
* Add mingw builds to Appveyor config
* Add getarch flags to disable AVX on x86
(and other small fixes to match Makefile behaviour)
* Make disabling DYNAMIC_ARCH on unsupported systems work
needs to be unset in the cache for the change to have any effect
* Mingw32 needs leading underscore on object names
(also copy BUNDERSCORE settings for FORTRAN from the corresponding Makefile)
sgemm_ncopy_4_skylakex.c uses SSE transpose operations where the
real perf win happens; this also works great for Haswell.
This gives double digit percentage gains on small and skinny matrices
with a few small changes it's possible to use the skylake sgemm code
also for haswell, this gives a modest gain (10% range) for smallish
matrixes but does wonders for very skinny matrixes
OpenBLAS has a fancy algorithm for copying the input data while laying
it out in a more CPU friendly memory layout.
This is great for large matrixes; the cost of the copy is easily
ammortized by the gains from the better memory layout.
But for small matrixes (on CPUs that can do efficient unaligned loads) this
copy can be a net loss.
This patch adds (for SKYLAKEX initially) a "sgemm direct" mode, that bypasses
the whole copy machinary for ALPHA=1/BETA=0/... standard arguments,
for small matrixes only.
What is small? For the non-threaded case this has been measured to be
in the M*N*K = 28 * 512 * 512 range, while in the threaded case it's
less, around M*N*K = 1 * 512 * 512
The Makefile variable parser in utils.cmake currently does not handle conditionals. Having the definitions for non-OSX last will at least make cmake builds work again on non-OSX platforms.
Plain cgemm_kernel and zgemm_kernel are not used anywhere, only cgemm_kernel_b etc.
Needlessly building them (without any define like NN, CN, etc.) just happened to work on most platforms, but not on arm64. See #1870
ARMv8 builds were a bit mixed up, with ThunderX2 code in ARMv8 mode
(which is not right because TX2 is ARMv8.1) as well as requiring a few
redundancies in the defines, making it harder to maintain and understand
what core has what. A few other minor issues were also fixed.
Tests were made on the following cores: A53, A57, A72, Falkor, ThunderX,
ThunderX2, and XGene.
Tests were: OpenBLAS/test, OpenBLAS/benchmark, BLAS-Tester.
A summary:
* Removed TX2 code from ARMv8 build, to make sure it is compatible with
all ARMv8 cores, not just v8.1. Also, the TX2 code has actually
harmed performance on big cores.
* Commoned up ARMv8 architectures' defines in params.h, to make sure
that all will benefit from ARMv8 settings, in addition to their own.
* Adding a few more cores, using ARMv8's include strategy, to benefit
from compiler optimisations using mtune. Also updated cache
information from the manuals, making sure we set good conservative
values by default. Removed Vulcan, as it's an alias to TX2.
* Auto-detecting most of those cores, but also updating the forced
compilation in getarch.c, to make sure the parameters are the same
whether compiled natively or forced arch.
Benefits:
* ARMv8 build is now guaranteed to work on all ARMv8 cores
* Improved performance for ARMv8 builds on some cores (A72, Falkor,
ThunderX1 and 2: up to 11%) over current develop
* Improved performance for *all* cores comparing to develop branch
before TX2's patch (9% ~ 36%)
* ThunderX1 builds are 14% faster than ARMv8 on TX1, 9% faster than
current develop's branch and 8% faster than deveop before tx2 patches
Issues:
* Regression from current develop branch for A53 (-12%) and A57 (-3%)
with ARMv8 builds, but still faster than before TX2's commit (+15%
and +24% respectively). This can be improved with a simplification of
TX2's code, to be done in future patches. At least the code is
guaranteed to be ARMv8.0 now.
Comments:
* CortexA57 builds are unchanged on A57 hardware from develop's branch,
which makes sense, as it's untouched.
* CortexA72 builds improve over A57 on A72 hardware, even if they're
using the same includes due to new compiler tunning in the makefile.
in the threading code there are cases where N or M can become 0,
and the optimized beta code did not handle this well, leading
to a crash
during the audit for the crash a few edge conditions on the if statements
were found and fixed as well
Enable DYNAMIC_ARCH feature on ARM64. This patch uses the cpuid
feature in linux kernel to detect the core type at runtime
(https://www.kernel.org/doc/Documentation/arm64/cpu-feature-registers.txt).
If this feature is missing in kernel, then the user should use the
OPENBLAS_CORETYPE env variable to select the desired core type.
Remove XGENE1 target as the implementation for the
same is incomplete. Moreover whoever wishes to use
on XGENE1 can use the generic ARMV8 target as there
are no XGENE1 specific optimizations in OpenBLAS.
Currently the generic ARMV8 target uses C implementations
for many routines. Replace these with the neon implementations
written for THUNDERX2T99 target which are upto 6x faster for
certain routines.