From 3df503cafd7d97eb53f8c8a9d6ab020442abca4b Mon Sep 17 00:00:00 2001 From: Martin Kroeker Date: Fri, 18 Jul 2025 23:41:57 +0200 Subject: [PATCH 1/3] portability fix and cleanup --- test/compare_sgemv_bgemv.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/test/compare_sgemv_bgemv.c b/test/compare_sgemv_bgemv.c index aac98760f..bab15deb1 100644 --- a/test/compare_sgemv_bgemv.c +++ b/test/compare_sgemv_bgemv.c @@ -100,7 +100,7 @@ int main(int argc, char *argv[]) SGEMV(&transA, &x, &x, &alpha, A, &x, B, &k, &beta, C, &k); BGEMV(&transA, &x, &x, &alpha_bf16, AA, &x, BB, &k, &beta_bf16, CC, &k); - for (int i = 0; i < x; i++) + for (i = 0; i < x; i++) DD[i] *= beta; for (j = 0; j < x; j++) @@ -118,14 +118,18 @@ int main(int argc, char *argv[]) { if (!is_close(float16to32(CC[j << l]), truncate_float32_to_bfloat16(C[j << l]), 0.01, 0.001)) { - printf("Mismatch at trans=%c, alpha=%.2f, beta=%.2f, i=%d, j=%d, k=%d: CC=%.6f, C=%.6f\n", +#ifdef DEBUG + printf("Mismatch at trans=%c, alpha=%.2f, beta=%.2f, i=%d, j=%d, k=%ld: CC=%.6f, C=%.6f\n", transA, alpha, beta, i, j, k, float16to32(CC[j << l]), truncate_float32_to_bfloat16(C[j << l])); +#endif ret++; } if (!is_close(float16to32(CC[j << l]), truncate_float32_to_bfloat16(DD[j]), 0.001, 0.0001)) { - printf("Mismatch at trans=%c, alpha=%.2f, beta=%.2f, i=%d, j=%d, k=%d: CC=%.6f, C=%.6f\n", +#ifdef DEBUG + printf("Mismatch at trans=%c, alpha=%.2f, beta=%.2f, i=%d, j=%d, k=%ld: CC=%.6f, C=%.6f\n", transA, alpha, beta, i, j, k, float16to32(CC[j << l]), truncate_float32_to_bfloat16(DD[j])); +#endif ret++; } } From 38e6999295e4e9d31c89c31db28dd32503cb9b63 Mon Sep 17 00:00:00 2001 From: Martin Kroeker Date: Fri, 18 Jul 2025 23:45:08 +0200 Subject: [PATCH 2/3] format cleanup --- test/compare_sgemm_bgemm.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/test/compare_sgemm_bgemm.c b/test/compare_sgemm_bgemm.c index f18fe1201..5358150d0 100644 --- a/test/compare_sgemm_bgemm.c +++ b/test/compare_sgemm_bgemm.c @@ -125,14 +125,18 @@ main (int argc, char *argv[]) float16to32 (AA[k * j + l]) * float16to32 (BB[i + l * n]); } if (!is_close(float16to32(CC[i * m + j]), truncate_float32_to_bfloat16(C[i * m + j]), 0.01, 0.001)) { - printf("Mismatch at i=%d, j=%d, k=%d: CC=%.6f, C=%.6f\n", +#ifdef DEBUG + printf("Mismatch at i=%d, j=%d, k=%ld: CC=%.6f, C=%.6f\n", i, j, k, float16to32(CC[i * m + j]), truncate_float32_to_bfloat16(C[i * m + j])); +#endif ret++; } if (!is_close(float16to32(CC[i * m + j]), truncate_float32_to_bfloat16(DD[i * m + j]), 0.0001, 0.00001)) { - printf("Mismatch at i=%d, j=%d, k=%d: CC=%.6f, DD=%.6f\n", +#ifdef DEBUG + printf("Mismatch at i=%d, j=%d, k=%ld: CC=%.6f, DD=%.6f\n", i, j, k, float16to32(CC[i * m + j]), truncate_float32_to_bfloat16(DD[i * m + j])); +#endif ret++; } From 30dbca5051e1c308eea6715dc2a79b959e5adaed Mon Sep 17 00:00:00 2001 From: Martin Kroeker Date: Fri, 18 Jul 2025 23:51:04 +0200 Subject: [PATCH 3/3] fix misleading indentation to silence a gcc warning --- interface/lapack/trtri.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/interface/lapack/trtri.c b/interface/lapack/trtri.c index df79f2665..82d806b8c 100644 --- a/interface/lapack/trtri.c +++ b/interface/lapack/trtri.c @@ -127,10 +127,10 @@ int NAME(char *UPLO, char *DIAG, blasint *N, FLOAT *a, blasint *ldA, blasint *In #endif #ifdef SMP -if (args.n <= 150) - args.nthreads = 1; -else - args.nthreads = num_cpu_avail(4); + if (args.n <= 150) + args.nthreads = 1; + else + args.nthreads = num_cpu_avail(4); if (args.nthreads == 1) { #endif