Browse Source

Fix integer overflow in threshold calculation

Related to lapack issue 135, the threshold calculation can overflow as well as the multiplication is evaluated from left to right.
Without explicit parentheses, the calculation would overflow for N >= 18919
pull/1135/head
Martin Kroeker GitHub 9 years ago
parent
commit
0ada2c02e2
1 changed files with 2 additions and 2 deletions
  1. +2
    -2
      lapack-netlib/SRC/sbdsqr.f

+ 2
- 2
lapack-netlib/SRC/sbdsqr.f View File

@@ -410,12 +410,12 @@
40 CONTINUE
50 CONTINUE
SMINOA = SMINOA / SQRT( REAL( N ) )
THRESH = MAX( TOL*SMINOA, MAXITR*N*N*UNFL )
THRESH = MAX( TOL*SMINOA, MAXITR*(N*(N*UNFL)) )
ELSE
*
* Absolute accuracy desired
*
THRESH = MAX( ABS( TOL )*SMAX, MAXITR*N*N*UNFL )
THRESH = MAX( ABS( TOL )*SMAX, MAXITR*(N*(N*UNFL)) )
END IF
*
* Prepare for main iteration loop for the singular values


Loading…
Cancel
Save