From f580c3d4693338f704fb2bcaf36d8a23410b1fa7 Mon Sep 17 00:00:00 2001 From: jjfeing Date: Mon, 16 Nov 2020 15:43:46 +0800 Subject: [PATCH] does not support summary when task sink and iter num > 1 --- mindspore/ccsrc/backend/session/ascend_session.cc | 2 ++ mindspore/ccsrc/backend/session/ascend_session.h | 1 + mindspore/ccsrc/backend/session/session_basic.cc | 5 +++++ mindspore/ccsrc/backend/session/session_basic.h | 1 + 4 files changed, 9 insertions(+) diff --git a/mindspore/ccsrc/backend/session/ascend_session.cc b/mindspore/ccsrc/backend/session/ascend_session.cc index 066bc6682b..3b881661b1 100644 --- a/mindspore/ccsrc/backend/session/ascend_session.cc +++ b/mindspore/ccsrc/backend/session/ascend_session.cc @@ -327,6 +327,8 @@ void AscendSession::CompileChildGraph(const KernelGraphPtr &child_graph) { runtime_instance->AssignStaticMemoryValueNode(child_graph.get()); } +bool AscendSession::IsSupportSummary() { return !device::KernelAdjust::NeedInsertSwitch(); } + void AscendSession::RunGraphImpl(const GraphId &graph_id, const std::vector &inputs, VectorRef *const outputs) { MS_LOG(INFO) << "Start"; diff --git a/mindspore/ccsrc/backend/session/ascend_session.h b/mindspore/ccsrc/backend/session/ascend_session.h index 0738bbe163..f1f4ddcd92 100644 --- a/mindspore/ccsrc/backend/session/ascend_session.h +++ b/mindspore/ccsrc/backend/session/ascend_session.h @@ -71,6 +71,7 @@ class AscendSession : public SessionBasic { GraphId CompileGraphImpl(const AnfNodePtrList &lst, const AnfNodePtrList &outputs) override; GraphId CompileGraphImpl(NotNull func_graph) override; GraphId CompileGraphImpl(NotNull func_graph, const std::vector &inputs) override; + bool IsSupportSummary() override; void RunGraphImpl(const GraphId &graph_id, const std::vector &inputs, VectorRef *outputs) override; void BuildGraphImpl(GraphId) override; void BuildOpImpl(const OpRunInfo &op_run_info, const GraphInfo &graph_info, diff --git a/mindspore/ccsrc/backend/session/session_basic.cc b/mindspore/ccsrc/backend/session/session_basic.cc index a3f2880355..45caa8a42e 100644 --- a/mindspore/ccsrc/backend/session/session_basic.cc +++ b/mindspore/ccsrc/backend/session/session_basic.cc @@ -1153,6 +1153,11 @@ void SessionBasic::Summary(KernelGraph *graph) { if (!exist_summary) { return; } + + if (!IsSupportSummary()) { + MS_LOG(ERROR) << "The Summary operator can not collect data correctly. Detail: the data sink mode is used and the" + " sink size(in model.train() python api) is not equal to 1."; + } SetSummaryNodes(graph); auto summary_outputs = graph->summary_nodes(); std::map params_list; diff --git a/mindspore/ccsrc/backend/session/session_basic.h b/mindspore/ccsrc/backend/session/session_basic.h index 158fe6c0a8..d984b4e48f 100644 --- a/mindspore/ccsrc/backend/session/session_basic.h +++ b/mindspore/ccsrc/backend/session/session_basic.h @@ -132,6 +132,7 @@ class SessionBasic : public std::enable_shared_from_this { friend class RunGraphTask; friend class BuildOpTask; friend class RunOpTask; + virtual bool IsSupportSummary() { return true; } virtual void CreateOutputTensors(const GraphId &graph_id, const std::vector &input_tensors, VectorRef *outputs, std::map *tensor_to_node);