!10918 clean condex

From: @hangangqiang
Reviewed-by: 
Signed-off-by:

mindspore/lite/src/lite_model.cc

@@ -63,6 +63,7 @@ int LiteModel::ConvertAttrToTensors(const void *meta_graph) {
   for (size_t index = 0; index < this->all_nodes_.size(); ++index) {
     std::vector<schema::Tensor *> dst_tensors;
     auto prim = meta_graph_v0->nodes()->GetAs<schema::v0::CNode>(index)->primitive();
+    MS_ASSERT(prim != nullptr);
     int status = ConvertAttrs(this->all_nodes_[index], prim, &dst_tensors);
     if (status != RET_OK) {
       MS_LOG(ERROR) << "fail to convert attr to tensor.";
@@ -97,6 +98,7 @@ void LiteModel::Free() {
   }
   for (auto &tensor_buf : attr_tensor_bufs_) {
     free(tensor_buf);
+    tensor_buf = nullptr;
   }
   attr_tensor_bufs_.resize(0);
 }

mindspore/lite/src/lite_model.h

@@ -66,6 +66,7 @@ class LiteModel : public Model {
         return false;
       }
       auto c_node = meta_graph.nodes()->template GetAs<U>(i);
+      MS_ASSERT(c_node != nullptr);
       auto src_prim = reinterpret_cast<const schema::Primitive *>(c_node->primitive());
 #ifdef PRIMITIVE_WRITEABLE
       node->primitive_ = PrimitiveC::Create(const_cast<schema::Primitive *>(src_prim));
@@ -86,8 +87,10 @@ class LiteModel : public Model {
         return false;
       }
       node->primitive_->set_quant_type(static_cast<schema::QuantType>(c_node->quantType()));
+      MS_ASSERT(c_node->name() != nullptr);
       node->name_ = c_node->name()->c_str();
       node->node_type_ = static_cast<NodeType>(c_node->nodeType());
+      MS_ASSERT(c_node->inputIndex() != nullptr);
       auto count = c_node->inputIndex()->size();
       for (uint32_t j = 0; j < count; ++j) {
         node->input_indices_.push_back(size_t(c_node->inputIndex()->template GetAs<uint32_t>(j)));
@@ -180,6 +183,7 @@ class LiteModel : public Model {
       }
     } else {
       auto sub_graphs = meta_graph.subGraph();
+      MS_ASSERT(sub_graphs != nullptr);
       auto sub_graph_size = sub_graphs->size();
       for (size_t i = 0; i < sub_graph_size; i++) {
         auto sub_graph = sub_graphs->template GetAs<schema::SubGraph>(i);

mindspore/lite/src/lite_session.cc

@@ -143,7 +143,7 @@ lite::Tensor *LiteSession::ConvertTensor(const schema::Tensor &src_tensor) {
       }
     }
   }
-  lite::Tensor *dst_tensor;
+  lite::Tensor *dst_tensor = nullptr;
   if (TypeId(src_tensor.dataType()) == kObjectTypeTensorType) {
     dst_tensor = new (std::nothrow) TensorList(shape, std::vector<int>(), src_category);
   } else {

mindspore/lite/tools/anf_exporter/anf_exporter.cc

@@ -268,12 +268,15 @@ int AnfExporter::ExportSubgraph(const FuncGraphPtr &func_graph, const std::uniqu
         auto partial_cnode = CreatePartialCnode(fg, cnode);
         primitive_c = GetValueNode<std::shared_ptr<PrimitiveC>>(partial_cnode->input(0));
         auto primT = primitive_c->primitiveT();
+        MS_ASSERT(primT != nullptr);
         auto pos = fg_subgraph_map.find(fg);
         if (pos != fg_subgraph_map.end()) {
+          MS_ASSERT(primT->value.AsPartial() != nullptr);
           primT->value.AsPartial()->subGraphIndex = fg_subgraph_map.at(fg);
         } else {
           size_t next_subgraph_index = fg_subgraph_map.size() + 1;
           fg_subgraph_map.insert(std::pair<FuncGraphPtr, int>{fg, next_subgraph_index});
+          MS_ASSERT(primT->value.AsPartial() != nullptr);
           primT->value.AsPartial()->subGraphIndex = next_subgraph_index;
           ret = ExportSubgraph(fg, meta_graphT, next_subgraph_index, keep_graph, copy_primitive, cnode);
           if (ret != RET_OK) {
@@ -730,6 +733,7 @@ void AnfExporter::SetOpOutputNode(const CNodePtr &cnode, const std::unique_ptr<s
 
       if (!utils::isa<abstract::AbstractTensorPtr>(elements[i])) {
         MS_LOG(ERROR) << "abstract is not AbstractTensor";
+        delete (msTensor);
         return;
       }
       auto type = kNumberTypeFloat32;
@@ -807,6 +811,7 @@ ValueNodePtr AnfExporter::GetPartialAnfPrim() {
   partial_primitiveT->value.value = new (std::nothrow) schema::PartialT;
   if (partial_primitiveT->value.value == nullptr) {
     MS_LOG(ERROR) << "new PartialT failed";
+    delete (partial_primitiveT);
     return nullptr;
   }
 

mindspore/lite/tools/anf_importer/import_from_mindir.cc

@@ -904,10 +904,12 @@ onnx::ModelProto *AnfImporterFromMindir::ReadOnnxFromBinary(const std::string &m
   }
   if (RET_OK != ValidateFileStr(model_path, ".mindir")) {
     MS_LOG(ERROR) << "INPUT ILLEGAL: modelFile must be *.mindir";
+    delete (onnx_model);
     return nullptr;
   }
   if (ReadProtoFromBinaryFile((const char *)model_path.c_str(), onnx_model) != RET_OK) {
     MS_LOG(ERROR) << "Read onnx model file failed, which is not a matched onnx model";
+    delete (onnx_model);
     return nullptr;
   }
   return onnx_model;

mindspore/lite/tools/anf_importer/import_from_mindir.h

@@ -75,8 +75,8 @@ class AnfImporterFromMindir : public AnfImporter {
   int ir_version_{};
   std::unordered_map<std::string, AnfNodePtr> anfnode_build_map_;
   std::map<std::string, onnx::TensorProto> default_para_map_;
-  onnx::ModelProto *onnx_model_;
-  FuncGraphPtr func_graph_;
+  onnx::ModelProto *onnx_model_ = nullptr;
+  FuncGraphPtr func_graph_ = nullptr;
 };
 }  // namespace mindspore::lite
 

mindspore/lite/tools/converter/legacy_optimizer/fusion/format_trans_fusion_pass.cc

@@ -103,6 +103,7 @@ STATUS FormatTransFusionPass::DoFusion(schema::MetaGraphT *graph, const std::str
   auto dstNode = graph->nodes.at(dstPath->nodeIdx).get();
   MS_ASSERT(srcNode != nullptr);
   MS_ASSERT(dstNode != nullptr);
+  MS_ASSERT(srcNode->primitive->value.AsTranspose() != nullptr);
   bool isNc2NhAndNh2Nc = srcNode->primitive->value.AsTranspose()->perm == nchw2nhwc_perm &&
                          dstNode->primitive->value.AsTranspose()->perm == nhwc2nchw_perm;
   bool isNh2NcAndNc2Nh = srcNode->primitive->value.AsTranspose()->perm == nhwc2nchw_perm &&

mindspore/lite/tools/converter/legacy_optimizer/graph/format_trans_pass.cc

@@ -233,6 +233,7 @@ NodeIter FormatTransPass::InsertFormatTransNode(schema::MetaGraphT *graph, NodeI
     transposeParam->perm.resize(inParam->perm.size());
     std::transform(inParam->perm.begin(), inParam->perm.end(), transposeParam->perm.begin(),
                    [](const int32_t ele) { return ele; });
+    MS_ASSERT(newOpDef->primitive != nullptr);
     newOpDef->primitive->value.value = transposeParam;
     return newOpDef;
   };

mindspore/lite/tools/converter/legacy_optimizer/graph/global_format_transform_pass.cc

@@ -41,6 +41,7 @@ STATUS GlobalFormatTransformPass::Run(MetaGraphT *graph) {
     if (type != PrimitiveType_Transpose) {
       continue;
     }
+    MS_ASSERT(pre_node->primitive->value.AsTranspose() != nullptr);
     if (node->primitive->value.AsTranspose()->perm != nchw2nhwc_perm) {
       continue;
     }
@@ -183,6 +184,7 @@ STATUS GlobalFormatTransformPass::FindPreNh2NcNodes(MetaGraphT *graph, size_t nc
       auto &pre_node = graph->nodes.at(input_node_index);
       MS_ASSERT(pre_node != nullptr);
       auto node_type = pre_node->primitive->value.type;
+      MS_ASSERT(pre_node->primitive->value.AsTranspose() != nullptr);
       if (node_type == schema::PrimitiveType_Transpose &&
           pre_node->primitive->value.AsTranspose()->perm == nhwc2nchw_perm) {
         if (!IsContain(*pre_nh2nc_nodes, input_node_index)) {

mindspore/lite/tools/converter/legacy_optimizer/graph/switch_pass.cc

@@ -96,7 +96,7 @@ STATUS SingleSwitchPass::UpdateSwitchUser() {
 
 bool SingleSwitchPass::IsLoop() {
   for (auto &node : second_graph_nodes_) {
-    if (node->primitive->value.type == schema::PrimitiveType_Partial &&
+    if (node->primitive->value.type == schema::PrimitiveType_Partial && node->primitive->value.AsPartial() != nullptr &&
         node->primitive->value.AsPartial()->subGraphIndex == first_subgraph_index_) {
       body_to_cond_partial_node_ = node;
       return true;
@@ -404,6 +404,7 @@ STATUS SingleSwitchPass::Init() {
   }
 
   // get cond_graph_nodes_
+  MS_ASSERT(first_partial_node_->primitive->value.AsPartial() != nullptr);
   first_subgraph_index_ = first_partial_node_->primitive->value.AsPartial()->subGraphIndex;
   auto cond_node_indices = graph_->subGraph.at(first_subgraph_index_)->nodeIndices;
   for (auto &index : cond_node_indices) {
@@ -411,6 +412,7 @@ STATUS SingleSwitchPass::Init() {
   }
 
   // get second_graph_nodes_
+  MS_ASSERT(second_partial_node_->primitive->value.AsPartial() != nullptr);
   second_subgraph_index_ = second_partial_node_->primitive->value.AsPartial()->subGraphIndex;
   auto body_node_indices = graph_->subGraph.at(second_subgraph_index_)->nodeIndices;
   for (auto &index : body_node_indices) {

mindspore/lite/tools/converter/legacy_optimizer/graph/trans_format_insert_pass.cc

@@ -44,6 +44,7 @@ bool TransOpInsertPass::CanFusion(schema::MetaGraphT *graph, const std::unique_p
     MS_ASSERT(pre_node->primitive->value != nullptr);
     if (pre_type_ == kNONE) {
       if (pre_node->primitive->value.type == schema::PrimitiveType_Transpose) {
+        MS_ASSERT(pre_node->primitive->value.AsTranspose() != nullptr);
         if (pre_node->primitive->value.AsTranspose()->perm == nchw2nhwc_perm) {
           pre_type_ = kNCHW2NHWC;
         } else if (pre_node->primitive->value.AsTranspose()->perm == nhwc2nchw_perm) {

mindspore/lite/tools/converter/legacy_optimizer/graph/trans_format_remove_pass.cc

@@ -35,8 +35,9 @@ STATUS TransOpRemovePass::Run(MetaGraphT *graph) {
   for (auto iter = graph->nodes.begin(); iter != graph->nodes.end(); iter++) {
     auto &node = *iter;
     auto type = node->primitive->value.type;
-    if (type == schema::PrimitiveType_Transpose && (node->primitive->value.AsTranspose()->perm == nchw2nhwc_perm ||
-                                                    node->primitive->value.AsTranspose()->perm == nhwc2nchw_perm)) {
+    if (type == schema::PrimitiveType_Transpose && node->primitive->value.AsTranspose() != nullptr &&
+        (node->primitive->value.AsTranspose()->perm == nchw2nhwc_perm ||
+         node->primitive->value.AsTranspose()->perm == nhwc2nchw_perm)) {
       auto &input_tensor = graph->allTensors.at(node->inputIndex.at(0));
       // less than 4 dims can delete
       if (!input_tensor->dims.empty() && input_tensor->dims.size() < 4) {

mindspore/lite/tools/converter/parser/caffe/caffe_model_parser.cc

@@ -356,7 +356,15 @@ STATUS CaffeModelParser::ConvertBlobs(const caffe::LayerParameter &layer, std::v
     } else {
       count = layer.blobs(i).data_size();
       auto buf = std::make_unique<float[]>(count);
+      if (buf == nullptr) {
+        MS_LOG(INFO) << "new buffer failed";
+        return RET_NULL_PTR;
+      }
       const float *data_ptr = layer.blobs(i).data().data();
+      if (data_ptr == nullptr) {
+        MS_LOG(INFO) << "data of origin layer is nullptr";
+        return RET_NULL_PTR;
+      }
       if (EOK != ::memcpy_s(buf.get(), count * sizeof(float), data_ptr, count * sizeof(float))) {
         MS_LOG(ERROR) << "memcpy_s failed.";
         return RET_ERROR;

mindspore/lite/tools/converter/parser/onnx/onnx_given_tensor_fill_parser.cc

@@ -43,6 +43,10 @@ STATUS OnnxGivenTensorFillParser::ParseInt8GivenIntTensorFill(const onnx::NodePr
     MS_LOG(ERROR) << "new char[] failed";
     return RET_MEMORY_FAILED;
   }
+  if (iter->ints().data() == nullptr) {
+    MS_LOG(ERROR) << "origin ints data in onnx is nullptr";
+    return RET_NULL_PTR;
+  }
   if (memcpy_s(param_data, data_size, iter->ints().data(), data_size) != EOK) {
     MS_LOG(ERROR) << "memcpy data failed.";
     delete[] param_data;

mindspore/lite/tools/converter/parser/onnx/onnx_model_parser.cc

@@ -1090,7 +1090,7 @@ STATUS OnnxModelParser::BuildCNodeForGemm(const onnx::NodeProto &onnx_node, cons
   return RET_OK;
 }
 
-STATUS OnnxModelParser::BuildParameterNodeForQuantParam(void *data, const std::string &name, TypeId type) {
+STATUS OnnxModelParser::BuildParameterNodeForQuantParam(const void *data, const std::string &name, TypeId type) {
   if (data == nullptr) {
     MS_LOG(ERROR) << "value is nullptr.";
     return RET_NULL_PTR;
@@ -1102,10 +1102,18 @@ STATUS OnnxModelParser::BuildParameterNodeForQuantParam(void *data, const std::s
   std::vector<int64_t> shape_vector;
   auto parameter_node = anf_root_graph_->add_parameter();
   auto abstract_tensor = std::make_shared<abstract::AbstractTensor>(TypeIdToType(type), shape_vector);
+  if (abstract_tensor == nullptr) {
+    MS_LOG(ERROR) << "new abstract_tensor failed";
+    return RET_MEMORY_FAILED;
+  }
   parameter_node->set_abstract(abstract_tensor);
   parameter_node->set_name(name);
   std::vector<int> shape;
   ParamValueLitePtr param_value = std::make_shared<ParamValueLite>();
+  if (param_value == nullptr) {
+    MS_LOG(ERROR) << "new param_value failed";
+    return RET_MEMORY_FAILED;
+  }
   param_value->set_tensor_shape(shape);
   param_value->set_format(schema::Format_NUM_OF_FORMAT);
   param_value->set_tensor_type(type);
@@ -1166,8 +1174,10 @@ STATUS OnnxModelParser::CopyOnnxTensorData(const onnx::TensorProto &onnx_const_t
     return RET_NULL_PTR;
   }
   size_t data_count = 1;
-  std::for_each(onnx_const_tensor.dims().begin(), onnx_const_tensor.dims().end(),
-                [&data_count](int dim) { data_count *= dim; });
+  if (!onnx_const_tensor.dims().empty()) {
+    std::for_each(onnx_const_tensor.dims().begin(), onnx_const_tensor.dims().end(),
+                  [&data_count](int dim) { data_count *= dim; });
+  }
   size_t data_size = 0;
   const void *onnx_data = nullptr;
   auto data_type = GetDataTypeFromOnnx(static_cast<onnx::TensorProto_DataType>(onnx_const_tensor.data_type()));
@@ -1209,6 +1219,10 @@ STATUS OnnxModelParser::CopyOnnxTensorData(const onnx::TensorProto &onnx_const_t
   if (data_size == 0) {
     return RET_OK;
   }
+  if (onnx_data == nullptr) {
+    MS_LOG(ERROR) << "origin data in onnx model is nullptr";
+    return RET_MEMORY_FAILED;
+  }
   char *param_data = new (std::nothrow) char[data_size];
   if (param_data == nullptr) {
     MS_LOG(ERROR) << "new char[] failed";

mindspore/lite/tools/converter/parser/onnx/onnx_model_parser.h

@@ -68,7 +68,7 @@ class OnnxModelParser : public ModelParser {
                              const std::unordered_map<std::string, AnfNodePtr> &anf_nodes_map);
   STATUS BuildReturnNode(const FuncGraphPtr &func_graph_ptr, const std::vector<AnfNodePtr> &return_inputs);
   STATUS BuildParameterNode(const ParameterPtr &parameter_node, const onnx::TensorProto &tensor);
-  STATUS BuildParameterNodeForQuantParam(void *data, const std::string &name, TypeId type);
+  STATUS BuildParameterNodeForQuantParam(const void *data, const std::string &name, TypeId type);
   STATUS BuildCNode(const onnx::NodeProto &onnx_node, const FuncGraphPtr &func_graph_ptr,
                     std::unordered_map<std::string, AnfNodePtr> *anf_nodes_map, std::vector<AnfNodePtr> *graph_inputs,
                     lite::PrimitiveC *primitive_c, std::string loop_name);

mindspore/lite/tools/converter/parser/onnx/onnx_node_parser.cc

@@ -41,6 +41,8 @@ schema::PadMode OnnxNodeParser::GetOnnxPadMode(const onnx::AttributeProto &onnx_
 
 STATUS OnnxNodeParser::GetTensorDataFromOnnx(const onnx::TensorProto &onnx_tensor, std::vector<float> *value,
                                              int *type) {
+  MS_ASSERT(value != nullptr);
+  MS_ASSERT(type != nullptr);
   size_t data_count = 1;
   std::for_each(onnx_tensor.dims().begin(), onnx_tensor.dims().end(), [&data_count](int dim) { data_count *= dim; });
   switch (onnx_tensor.data_type()) {

mindspore/lite/tools/converter/parser/tf/tf_util.cc

@@ -85,7 +85,6 @@ schema::Format TensorFlowUtils::ParseNodeFormat(const tensorflow::NodeDef &node_
 
 bool TensorFlowUtils::DecodeInt64(std::string_view *str_view, uint64_t *value) {
   if (str_view == nullptr || value == nullptr) {
-    *value = 0;
     MS_LOG(ERROR) << "str_view or value is nullptr";
     return false;
   }

mindspore/lite/tools/optimizer/graph/while_pass.cc

@@ -40,6 +40,7 @@ ValueNodePtr WhilePass::GetSwitchAnfPrim() {
   switch_primitiveT->value.value = new (std::nothrow) schema::SwitchT;
   if (switch_primitiveT->value.value == nullptr) {
     MS_LOG(ERROR) << "new MakeTupleT failed";
+    delete (switch_primitiveT);
     return nullptr;
   }