From 706054eb46c1055fa9cf4b33e9485db99f8dbe1e Mon Sep 17 00:00:00 2001
From: seatea <t.cai@huawei.com>
Date: Thu, 28 May 2020 15:43:19 +0800
Subject: [PATCH] Fix reviewbot warning for `debug`, `ir`, `optimizer`,
 `pipeline`, `utils` and `vm` modules.

---
 mindspore/ccsrc/debug/trace_info.h                         | 2 +-
 mindspore/ccsrc/ir/param_value_py.h                        | 2 +-
 mindspore/ccsrc/pipeline/static_analysis/static_analysis.h | 1 -
 mindspore/ccsrc/vm/vm.cc                                   | 6 ++++--
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/mindspore/ccsrc/debug/trace_info.h b/mindspore/ccsrc/debug/trace_info.h
index 63551ba10e..19c07bdbbc 100644
--- a/mindspore/ccsrc/debug/trace_info.h
+++ b/mindspore/ccsrc/debug/trace_info.h
@@ -45,7 +45,7 @@ class TraceInfo : public Base {
   }
   TraceInfo(const TraceInfo &info)
       : Base(), debug_info_(info.debug_info_), symbol_(info.symbol_), full_name_(info.full_name_), name_(info.name_) {}
-  virtual ~TraceInfo() = default;
+  ~TraceInfo() override = default;
   MS_DECLARE_PARENT(TraceInfo, Base);
   virtual std::string name() { return name_; }
   virtual std::string symbol() { return symbol_; }
diff --git a/mindspore/ccsrc/ir/param_value_py.h b/mindspore/ccsrc/ir/param_value_py.h
index 087dffaf60..6841f4c040 100644
--- a/mindspore/ccsrc/ir/param_value_py.h
+++ b/mindspore/ccsrc/ir/param_value_py.h
@@ -29,7 +29,7 @@ class ParamValuePy : public ParamValue {
  public:
   ParamValuePy() : value_(py::none()) {}
   explicit ParamValuePy(py::object value) : value_(value) {}
-  virtual ~ParamValuePy() = default;
+  ~ParamValuePy() override = default;
 
   py::object value() { return value_; }
   void set_value(const py::object &obj) { value_ = obj; }
diff --git a/mindspore/ccsrc/pipeline/static_analysis/static_analysis.h b/mindspore/ccsrc/pipeline/static_analysis/static_analysis.h
index 7c54726602..1e7a52fda9 100644
--- a/mindspore/ccsrc/pipeline/static_analysis/static_analysis.h
+++ b/mindspore/ccsrc/pipeline/static_analysis/static_analysis.h
@@ -40,7 +40,6 @@
 
 namespace mindspore {
 namespace abstract {
-
 // define attribute value map
 using AttrValueMap = std::unordered_map<std::string, ValuePtr>;
 using AttrValueMapPtr = std::shared_ptr<AttrValueMap>;
diff --git a/mindspore/ccsrc/vm/vm.cc b/mindspore/ccsrc/vm/vm.cc
index 2df475c39d..06ed0627d0 100644
--- a/mindspore/ccsrc/vm/vm.cc
+++ b/mindspore/ccsrc/vm/vm.cc
@@ -603,8 +603,9 @@ void FinalVM::InstPushPrim(const VectorRef &args) {
 }
 
 BaseRef FinalVM::RunHook(const PrimitivePtr &prim, const VectorRef &args) {
-  py::tuple py_args = py::tuple(args.size());
   MS_LOG(DEBUG) << "input for operation:";
+  std::size_t args_size = args.size();
+  py::tuple py_args = py::tuple(args_size);
   size_t i = 0;
   for (auto &arg : args) {
     py_args[i] = BaseRefToPyData(arg);
@@ -622,7 +623,8 @@ BaseRef FinalVM::RunHook(const PrimitivePtr &prim, const VectorRef &args) {
   if (is_cell) {
     std::string cell_id = GetValue<std::string>(prim->GetAttr("cell_id"));
     if (_hook_grad.find(cell_id) != _hook_grad.end()) {
-      py::tuple hook_args = py::tuple(3);
+      std::size_t hook_args_size = 3;
+      py::tuple hook_args = py::tuple(hook_args_size);
       hook_args[0] = cell_id;
       hook_args[1] = py::make_tuple(_hook_grad[cell_id]);
       hook_args[2] = py::make_tuple(py_args[2]);