From fc70687d52ab27fa9d2f51394e8d07664b3cc8b6 Mon Sep 17 00:00:00 2001 From: luopengting Date: Thu, 29 Oct 2020 10:04:36 +0800 Subject: [PATCH] change the error message about the `type` in optimizer config from list_err_msg to str_err_msg --- mindinsight/optimizer/common/validator/optimizer_config.py | 2 +- tests/ut/optimizer/common/validator/test_optimizer_config.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/mindinsight/optimizer/common/validator/optimizer_config.py b/mindinsight/optimizer/common/validator/optimizer_config.py index 7d092edc..f6e6311a 100644 --- a/mindinsight/optimizer/common/validator/optimizer_config.py +++ b/mindinsight/optimizer/common/validator/optimizer_config.py @@ -79,7 +79,7 @@ class ParameterSchema(Schema): bounds = fields.List(fields.Number(error_messages=number_err_msg), error_messages=list_err_msg) choice = fields.List(fields.Number(error_messages=number_err_msg), error_messages=list_err_msg) - type = fields.Str(error_messages=list_err_msg) + type = fields.Str(error_messages=str_err_msg) source = fields.Str(error_messages=str_err_msg) @validates("bounds") diff --git a/tests/ut/optimizer/common/validator/test_optimizer_config.py b/tests/ut/optimizer/common/validator/test_optimizer_config.py index 7be0379a..08614ff8 100644 --- a/tests/ut/optimizer/common/validator/test_optimizer_config.py +++ b/tests/ut/optimizer/common/validator/test_optimizer_config.py @@ -65,12 +65,14 @@ class TestOptimizerConfig: config_dict['target']['goal'] = init_list config_dict['parameters']['learning_rate']['bounds'] = init_str config_dict['parameters']['learning_rate']['choice'] = init_str + config_dict['parameters']['learning_rate']['type'] = init_list expected_err = { 'command': ["Value type should be 'str'."], 'parameters': { 'learning_rate': { 'bounds': ["Value type should be 'list'."], - 'choice': ["Value type should be 'list'."] + 'choice': ["Value type should be 'list'."], + 'type': ["Value type should be 'str'."] } }, 'summary_base_dir': ["Value type should be 'str'."],