diff --git a/abl/evaluation/semantics_metric.py b/abl/evaluation/semantics_metric.py index 3ddb24c..718cfea 100644 --- a/abl/evaluation/semantics_metric.py +++ b/abl/evaluation/semantics_metric.py @@ -11,12 +11,12 @@ class SemanticsMetric(BaseMetric): def process(self, data_samples: Sequence[dict]) -> None: for data_sample in data_samples: - if self.kb.entail(data_sample, data_sample["Y"][0]): + if self.kb.check_equal(data_sample, data_sample["Y"][0]): self.results.append(1) else: self.results.append(0) - + def compute_metrics(self, results: list) -> dict: metrics = dict() metrics["semantics_accuracy"] = sum(results) / len(results) - return metrics \ No newline at end of file + return metrics diff --git a/abl/reasoning/search_based_kb.py b/abl/reasoning/search_based_kb.py index 4598edd..fb32e7f 100644 --- a/abl/reasoning/search_based_kb.py +++ b/abl/reasoning/search_based_kb.py @@ -53,8 +53,8 @@ class SearchBasedKB(BaseKB, ABC): ) @abstractmethod - def entail(self, data_sample: ListData, y: Any): - """Placeholder for entail.""" + def check_equal(self, data_sample: ListData, y: Any): + """Placeholder for check_equal.""" pass def abduce_candidates( @@ -75,7 +75,7 @@ class SearchBasedKB(BaseKB, ABC): for i, idx in enumerate(revision_idx): candidate[idx] = c[i] new_data_sample["pred_pseudo_label"][0] = candidate - if self.entail(new_data_sample, new_data_sample["Y"][0]): + if self.check_equal(new_data_sample, new_data_sample["Y"][0]): candidates.append(candidate) return candidates diff --git a/examples/hwf/hwf_kb.py b/examples/hwf/hwf_kb.py index ad3fb0b..9f91c8c 100644 --- a/examples/hwf/hwf_kb.py +++ b/examples/hwf/hwf_kb.py @@ -32,7 +32,7 @@ class HWF_KB(GroundKB): data_sample["Y"] = [eval("".join(formula))] return data_sample["Y"][0] - def entail(self, data_sample: ListData, y: Any): + def check_equal(self, data_sample: ListData, y: Any): if not self._valid_candidate(data_sample): return False formula = data_sample["pred_pseudo_label"][0] diff --git a/examples/mnist_add/mnist_add_kb.py b/examples/mnist_add/mnist_add_kb.py index 8b15064..258b92e 100644 --- a/examples/mnist_add/mnist_add_kb.py +++ b/examples/mnist_add/mnist_add_kb.py @@ -15,7 +15,7 @@ class AddKB(SearchBasedKB): def get_key(self, data_sample: ListData): return (data_sample.to_tuple("pred_pseudo_label"), data_sample["Y"][0]) - def entail(self, data_sample: ListData, y: Any): + def check_equal(self, data_sample: ListData, y: Any): return self.logic_forward(data_sample) == y def logic_forward(self, data_sample):